feat: update with confirmed transaction rather than finalized

Author: Battambang

packages/snap/integration-test/client-request.test.ts

@@ -113,10 +113,10 @@ describe('OnClientRequestHandler', () => {
 
     /* eslint-disable @typescript-eslint/naming-convention */
     expect(finalSyncResponse).toTrackEvent({
-      event: TrackingSnapEvent.TransactionFinalized,
+      event: TrackingSnapEvent.TransactionConfirmed,
       properties: {
         origin: 'cron',
-        message: 'Snap transaction finalized',
+        message: 'Snap transaction confirmed',
         chain_id_caip: BtcScope.Regtest,
         account_type: BtcAccountType.P2wpkh,
         tx_id: transactionId,

packages/snap/src/entities/snap.ts

@@ -28,7 +28,7 @@ export type AccountState = {
 };
 
 export enum TrackingSnapEvent {
-  TransactionFinalized = 'Transaction Finalized',
+  TransactionConfirmed = 'Transaction Confirmed',
   TransactionReceived = 'Transaction Received',
   TransactionReorged = 'Transaction Reorged',
   TransactionSubmitted = 'Transaction Submitted',

packages/snap/src/infra/SnapClientAdapter.ts

@@ -254,8 +254,8 @@ export class SnapClientAdapter implements SnapClient {
   ): Promise<void> {
     const createMessage = (): string => {
       switch (eventType) {
-        case TrackingSnapEvent.TransactionFinalized:
-          return 'Snap transaction finalized';
+        case TrackingSnapEvent.TransactionConfirmed:
+          return 'Snap transaction confirmed';
         case TrackingSnapEvent.TransactionSubmitted:
           return 'Snap transaction submitted';
         case TrackingSnapEvent.TransactionReorged:

packages/snap/src/use-cases/AccountUseCases.test.ts

@@ -499,7 +499,7 @@ describe('AccountUseCases', () => {
         mockSnapClient.emitAccountTransactionsUpdatedEvent,
       ).toHaveBeenCalledWith(mockAccount, [mockTxConfirmed]);
       expect(mockSnapClient.emitTrackingEvent).toHaveBeenCalledWith(
-        TrackingSnapEvent.TransactionFinalized,
+        TrackingSnapEvent.TransactionConfirmed,
         mockAccount,
         mockTxConfirmed,
         'test',
@@ -566,9 +566,9 @@ describe('AccountUseCases', () => {
         mockTxReorged,
       ]);
 
-      // Check for TransactionFinalized event for confirmed transaction
+      // Check for TransactionConfirmed event for confirmed transaction
       expect(mockSnapClient.emitTrackingEvent).toHaveBeenCalledWith(
-        TrackingSnapEvent.TransactionFinalized,
+        TrackingSnapEvent.TransactionConfirmed,
         mockAccount,
         mockTxConfirmed,
         origin,

packages/snap/src/use-cases/AccountUseCases.ts

@@ -267,13 +267,13 @@ export class AccountUseCases {
           await runSnapActionSafely(
             async () =>
               this.#snapClient.emitTrackingEvent(
-                TrackingSnapEvent.TransactionFinalized,
+                TrackingSnapEvent.TransactionConfirmed,
                 account,
                 tx,
                 origin,
               ),
             this.#logger,
-            'emitTrackingEvent:TransactionFinalized',
+            'emitTrackingEvent:TransactionConfirmed',
           );
         } else {
           // if the status was changed, and now it's NOT confirmed