Fix tests and re-order fetch notification

Author: FrederikBolding

packages/snaps-controllers/coverage.json

@@ -1,6 +1,6 @@
 {
-  "branches": 93.51,
+  "branches": 93.09,
   "functions": 97.36,
-  "lines": 98.33,
-  "statements": 98.17
+  "lines": 98.19,
+  "statements": 98.03
 }

packages/snaps-execution-environments/coverage.json

@@ -1,6 +1,6 @@
 {
-  "branches": 90,
+  "branches": 89.89,
   "functions": 94.57,
-  "lines": 90.14,
-  "statements": 89.51
+  "lines": 89.88,
+  "statements": 89.24
 }

packages/snaps-execution-environments/src/common/BaseSnapExecutor.test.browser.ts

@@ -264,12 +264,6 @@ describe('BaseSnapExecutor', () => {
       },
     });
 
-    expect(await executor.readCommand()).toStrictEqual({
-      jsonrpc: '2.0',
-      method: 'OutboundResponse',
-      params: { source: 'snap.request' },
-    });
-
     expect(await executor.readCommand()).toStrictEqual({
       id: 2,
       jsonrpc: '2.0',
@@ -407,12 +401,6 @@ describe('BaseSnapExecutor', () => {
       ],
     });
 
-    expect(await executor.readCommand()).toStrictEqual({
-      jsonrpc: '2.0',
-      method: 'OutboundRequest',
-      params: { source: 'snap.request' },
-    });
-
     const getSnapsRequest = await executor.readRpc();
     expect(getSnapsRequest).toStrictEqual({
       name: 'metamask-provider',
@@ -441,12 +429,6 @@ describe('BaseSnapExecutor', () => {
       },
     });
 
-    expect(await executor.readCommand()).toStrictEqual({
-      jsonrpc: '2.0',
-      method: 'OutboundResponse',
-      params: { source: 'snap.request' },
-    });
-
     expect(await executor.readCommand()).toStrictEqual({
       id: 2,
       jsonrpc: '2.0',
@@ -778,12 +760,6 @@ describe('BaseSnapExecutor', () => {
       ],
     });
 
-    expect(await executor.readCommand()).toStrictEqual({
-      jsonrpc: '2.0',
-      method: 'OutboundRequest',
-      params: { source: 'snap.request' },
-    });
-
     const request = await executor.readRpc();
     expect(request).toStrictEqual({
       name: 'metamask-provider',
@@ -811,12 +787,6 @@ describe('BaseSnapExecutor', () => {
       },
     });
 
-    expect(await executor.readCommand()).toStrictEqual({
-      jsonrpc: '2.0',
-      method: 'OutboundResponse',
-      params: { source: 'snap.request' },
-    });
-
     expect(await executor.readCommand()).toStrictEqual({
       id: 2,
       jsonrpc: '2.0',

packages/snaps-execution-environments/src/common/endowments/network.ts

@@ -226,14 +226,14 @@ const createNetwork = ({ notify }: EndowmentFactoryOptions = {}) => {
     return await withTeardown(
       (async () => {
         try {
-          await notify({
-            method: 'OutboundRequest',
-            params: { source: 'fetch' },
-          });
           const fetchPromise = fetch(input, {
             ...init,
             signal: abortController.signal,
           });
+          await notify({
+            method: 'OutboundRequest',
+            params: { source: 'fetch' },
+          });
 
           openFetchConnection = {
             cancel: async () => {