Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the native account picker #2752

Closed
eriknson opened this issue Sep 23, 2024 · 4 comments · Fixed by #2764
Closed

Expose the native account picker #2752

eriknson opened this issue Sep 23, 2024 · 4 comments · Fixed by #2764
Assignees
@GuillaumeRx
Labels
team-accounts team-snaps

Comments

@eriknson
Copy link
Member

eriknson commented Sep 23, 2024 •
edited
Loading

Component used to expose the native account picker, while the data & logic itself stays on the extension-side (i.e. not exposing all accounts etc. to the snap, just returning the selected one)
@eriknson
Copy link
Member Author

@Montoya & engineering to spec this up technically with input from the accounts team

@eriknson
Copy link
Member Author

Screenshot 2024-09-23 at 14 02 57

@eriknson eriknson mentioned this issue Sep 23, 2024
Open
@eriknson
Copy link
Member Author

We need to know what should be returned (to the snap) from the account picker

@eriknson
Copy link
Member Author

We think it's called <AccountPicker> in the DS

@GuillaumeRx GuillaumeRx self-assigned this Sep 26, 2024
@GuillaumeRx GuillaumeRx mentioned this issue Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeRx GuillaumeRx

Labels
team-accounts team-snaps
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add AccountSelector component MetaMask/snaps
2 participants
@GuillaumeRx @eriknson