Skip to content

dawn4py utils.py issues #1104

@BenWeber42

Description

@BenWeber42

I think make_magic_num_interval should be added to __all__ : https://github.com/MeteoSwiss-APN/dawn/blob/master/dawn/src/dawn4py/serialization/utils.py
Also, python doesn't have overloading, so this is a bug:

def make_vertical_region_decl_stmt(vertical_region: VerticalRegion) -> VerticalRegionDeclStmt:
""" Create a VerticalRegionDeclStmt
:param vertical_region: Vertical region.
"""
stmt = VerticalRegionDeclStmt()
stmt.vertical_region.CopyFrom(vertical_region)
return stmt
def make_vertical_region_decl_stmt(
ast: AST,
interval: Interval,
loop_order: VerticalRegion.LoopOrder,
IRange: Interval = None,
JRange: Interval = None,
) -> VerticalRegionDeclStmt:
""" Create a VerticalRegionDeclStmt
:param vertical_region: Vertical region.
"""
stmt = VerticalRegionDeclStmt()
stmt.vertical_region.CopyFrom(make_vertical_region(
ast, interval, loop_order, IRange, JRange))
return stmt

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions