Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set up local rules for non-community servers. #122

Open
Jasius opened this issue Sep 10, 2021 · 0 comments
Open

Ability to set up local rules for non-community servers. #122

Jasius opened this issue Sep 10, 2021 · 0 comments
Labels
enhancement New feature or request Hacktoberfest

Comments

@Jasius
Copy link
Member

Jasius commented Sep 10, 2021

Hey, I've been on kayaking trip so haven't had time to do a review up until now. Thank you for this thoughtful PR, I've ran through this code once and added some changes(mostly copywriting suggestions)

Also tried running this on a server without community rules set up and it didn't seem to fail gracefuly, just popped off some messaging and errors in the logs.
image

Going to do more testing now.

I didn't implement that, currently it uses "fetchRules()" but we need something like an interface that fallback to custom rules if it's not a community server: like we need a new command to set up custom rules in the bot, or maybe make the bot use a #rules channel and parse rules from there, need to think more about it

Originally posted by @lost-in-action in #114 (comment)

@Jasius Jasius added enhancement New feature or request Hacktoberfest labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant