Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Client #162

Open
3 tasks
hawkerm opened this issue Oct 17, 2019 · 1 comment
Open
3 tasks

Add .NET Client #162

hawkerm opened this issue Oct 17, 2019 · 1 comment

Comments

@hawkerm
Copy link
Member

hawkerm commented Oct 17, 2019

@lee-11 and @mlhpdx I was looking at the network for Space Battle and stumbled upon your fork adding .NET Core support!

Would you be interested in helping to submit a PR to add it to our official repo?

The main comments I have on the implementation are:

  • Use PascalCasing for methods to align to C# naming conventions
  • Also allow typing 'quit' in the console to exit the program (I believe this should make it work to use with F5 in VS Code as well, as Ctrl+C doesn't work there).
  • Copy the java example ships for the test ship directory as individual ship files.
@mlhpdx
Copy link

mlhpdx commented Oct 17, 2019

Yep. I was going to get back to this again soon. Still teaching Unit 3 right now, but I'll find some time to make this port a little nicer and if it makes sense PR it.

@hawkerm hawkerm added this to the v1.3 - TBA milestone Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants