Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (system card) mocks #298

Closed
7 of 9 tasks
anneschuth opened this issue Oct 21, 2024 · 1 comment · Fixed by #320
Closed
7 of 9 tasks

Remove (system card) mocks #298

anneschuth opened this issue Oct 21, 2024 · 1 comment · Fixed by #320
Assignees

Comments

@anneschuth
Copy link
Member

anneschuth commented Oct 21, 2024

  • We remove all mocking from the AMT and move everything related to system_cards to the Project.system_card (serialized to the db)
  • out of scope:
  • We keep the file system storage abstractions around
  • We may want to keep only the option to mock (through selecting a default template) when creating a project?
  • out of scope is increasing the test coverage: Bring test coverage back #312
@anneschuth anneschuth converted this from a draft issue Oct 21, 2024
@uittenbroekrobbert uittenbroekrobbert self-assigned this Oct 25, 2024
@uittenbroekrobbert uittenbroekrobbert linked a pull request Oct 28, 2024 that will close this issue
5 tasks
@uittenbroekrobbert
Copy link
Contributor

For implementation of using the template when creating a new project; A hidden field is used instead of the option to select a template, as the latter would make things more complicated at this point. This is by request of @robbertbos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants