Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match-v5 ChallengesDto's field "bountyGold" is incorrectly documented as an int when it can be a float [upstream] #74

Closed
NotTheEconomist opened this issue Nov 3, 2024 · 1 comment

Comments

@NotTheEconomist
Copy link

Just a bit of a note to drive development if and when Riot fixes the API documentation. Looks like bountyGold in the ChallengesDto is incorrectly documented as an int while it can return a float.

Upstream issue: RiotGames/developer-relations#1005

Repro steps:

let api = RiotApi::new(MY_API_KEY);
let match_id = "NA1_5145391102";
api.match_v5().get_match(PlatformRoute::NA1.to_regional(), match_id).await.expect("This will panic!")
@MingweiSamuel
Copy link
Owner

Fixed in 381db0f released Riven 2.57.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants