Skip to content

Missing encoding argument for pipe open #200

Open
@aklein3

Description

@aklein3

The call to open() to terminate MiniZinc on Windows omits the encoding argument. This triggers an EncodingWarning if warnings are enabled (-W default).

The fix is as follows:

--- a/src/minizinc/instance.py
+++ b/src/minizinc/instance.py
@@ -675,7 +675,8 @@ class Instance(Model):
                 # First, terminate the process
                 if sys.platform == "win32":
                     with open(
-                        f"\\\\.\\pipe\\minizinc-{proc.pid}", mode="w"
+                        f"\\\\.\\pipe\\minizinc-{proc.pid}", mode="w",
+                        encoding="utf8"
                     ) as named_pipe:
                         # Trigger MiniZinc termination
                         named_pipe.write("")

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions