-
-
Notifications
You must be signed in to change notification settings - Fork 122
Developers wiki: Pull requests
Kevin Woo edited this page Apr 8, 2019
·
9 revisions
mmg is an open source project so your contributions are welcome. You can help us to improve the mmg applications through:
- bug fixes
- features development.
The steps to contribute to the mmg project are detailed in the next paragraphs.
To see your work included in the project, please:
-
agree and fill the mmg-platform-corporate-contributor-assignment-agreement if the intellectual property of the contributed code belongs to your employer or the mmg-platform-individual-contributor-assignment-agreement if it belongs to you;
-
ask first before implementing any features;
-
do not perform code refactoring;
-
adopt our coding conventions:
- use our indentation convention (2 spaces instead of tabulations);
- write accurate Doxygen comments (see for example the documentation of the API_functions.c file);
- write accurate commit messages;
- run the continuous integration test before opening any pull request.
-
agree to license your work under the GNU Lesser General Public License.
To contribute to the mmg software:
-
- fork the project on GitHub and clone your fork:
git clone https://github.com/<username>/mmg
-
- checkout the develop branch and assign the original mmg repository to a remote named upstream:
git checkout develop
git remote add upstream https://github.com/MmgTools/mmg
-
- get the last changes from branch develop of the upstream in your own develop branch:
git checkout develop
git pull upstream develop
-
- create a new branch to develop your feature:
git checkout -b myFeature
-
- merge the upstream develop branch into your feature branch:
git merge develop
-
- if you want, you can push your feature branch up to your repository:
git push origin myfeature
-
- contribute to the code. Don't forget to regularly merge the upstream develop branch into your feature branch:
git pull upstream develop
to avoid painful merge after huge modifications;
- contribute to the code. Don't forget to regularly merge the upstream develop branch into your feature branch:
-
- open a pull request with title and detailed description.