Skip to content

BlockTripsWithOverlappingStopTimesNotice error not being caught #1089

@rpedraza01

Description

@rpedraza01

Bug report

Describe the bug
Trillium Solutions is building a UI for the gtfs-validator. During our QA process, we encountered a potential bug in which the validator tool doesn't catch overlapping blocks and the BlockTripsWithOverlappingStopTimesNotice rule doesn't get triggered. We've created a GTFS dataset with purposely "bad" data to test the validator.

How we reproduce the bug
Steps to reproduce the behaviour:

  1. Find a GTFS dataset with known block overlaps or use the file we created
    (gtfs-validator-test-us.zip).
  2. Run your GTFS dataset of choice through the gtfs-validator.
  3. Read through the output searching for the BlockTripsWithOverlappingStopTimesNotice error but not find the error message.

Expected behaviour
We would expect the BlockTripsWithOverlappingStopTimesNotice error message to appear with all necessary identifying data points to allow a user to make corrections to the dataset.

Observed behaviour
BlockTripsWithOverlappingStopTimesNotice doesn't appear to be working properly.

Screenshots:
Screen Shot 2022-01-27 at 15 47 08
Image is from Trillium Solutions GTFS Manager software
There are six block overlaps that our own software is catching but gtfs-validator isn't.

We think investigating this possible bug at this file location would be a good start main/src/test/java/org/mobilitydata/gtfsvalidator/validator/ and adding more test cases here.

Environment versions

  • validator version: 3.0
  • Java version: 11
  • OS versions: macOS 10.15.7

Please let me know if there's any other info y'all need.

Metadata

Metadata

Assignees

Labels

GTFS ReferenceUsed for Adding or changing rules that belong in the GTFS referencebugSomething isn't working (crash, a rule has a problem)dependenciesPull requests that update a dependency filestatus: Work in progressA PR that would close this issue has been opened.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions