Skip to content
This repository was archived by the owner on May 24, 2025. It is now read-only.
This repository was archived by the owner on May 24, 2025. It is now read-only.

Can't use non-count ECFP with useFeatures = True #53

Open
@JanoschMenke

Description

@JanoschMenke

Hi I think there is an error when calculating the ECFP when setting use_counts = False and use_features = True, which leads to ECFP being used that does not use useFeatures=True in the generation of the fingerprint. Could that be due to a different function being used when use_counts=False

I assume this function then is called, which does not appear to use the useFeatures�parameter:

def molecules_to_fingerprints(self, molecules: List[Mol], parameters: {}) -> List[np.ndarray]:
    radius = parameters.get('radius', 3)
    size = parameters.get('size', 2048)
    fp_bits = [AllChem.GetMorganFingerprintAsBitVect(mol, radius, size) for mol in molecules]
    fingerprints = [self._numpy_fingerprint(fp, dtype=np.int32) for fp in fp_bits]
    return fingerprints

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions