feat: include new image opencode #14
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
![pr-agent-monadical[bot]](https://avatars.githubusercontent.com/u/29933591?s=60&v=4){kind=small}
| pre_command: /cubbi-init.sh | ||
| command: /entrypoint.sh |
There was a problem hiding this comment.
Suggestion: The init commands in cubbi_image.yaml reference /cubbi-init.sh and /entrypoint.sh, but these files don't appear to be created or copied in the Dockerfile. This will cause initialization failures. [possible issue, importance: 9]
| pre_command: /cubbi-init.sh | |
| command: /entrypoint.sh | |
| init: | |
| pre_command: /cubbi/cubbi_init.py | |
| command: tail -f /dev/null |
| def _ensure_user_config_dir(self) -> Path: | ||
| """Ensure config directory exists with correct ownership""" | ||
| config_dir = self._get_user_config_path() | ||
|
|
||
| # Create the full directory path | ||
| try: | ||
| config_dir.mkdir(parents=True, exist_ok=True) | ||
| except FileExistsError: | ||
| # Directory already exists, which is fine | ||
| pass | ||
| except OSError as e: | ||
| self.status.log( | ||
| f"Failed to create config directory {config_dir}: {e}", "ERROR" | ||
| ) | ||
| return config_dir |
There was a problem hiding this comment.
Suggestion: The _ensure_user_config_dir method returns config_dir even after logging an error, which could lead to subsequent operations on a non-existent directory. Consider raising an exception or implementing proper error handling. [possible issue, importance: 7]
| def _ensure_user_config_dir(self) -> Path: | |
| """Ensure config directory exists with correct ownership""" | |
| config_dir = self._get_user_config_path() | |
| # Create the full directory path | |
| try: | |
| config_dir.mkdir(parents=True, exist_ok=True) | |
| except FileExistsError: | |
| # Directory already exists, which is fine | |
| pass | |
| except OSError as e: | |
| self.status.log( | |
| f"Failed to create config directory {config_dir}: {e}", "ERROR" | |
| ) | |
| return config_dir | |
| def _ensure_user_config_dir(self) -> Path: | |
| """Ensure config directory exists with correct ownership""" | |
| config_dir = self._get_user_config_path() | |
| # Create the full directory path | |
| try: | |
| config_dir.mkdir(parents=True, exist_ok=True) | |
| except FileExistsError: | |
| # Directory already exists, which is fine | |
| pass | |
| except OSError as e: | |
| self.status.log( | |
| f"Failed to create config directory {config_dir}: {e}", "ERROR" | |
| ) | |
| raise RuntimeError(f"Failed to create config directory: {e}") | |
| # Set ownership for the directories | |
| config_parent = config_dir.parent | |
| if config_parent.exists(): | |
| self._set_ownership(config_parent) | |
| if config_dir.exists(): | |
| self._set_ownership(config_dir) | |
| return config_dir |
User description
Summary
This PR add a new image for supporting opencode
PR Type
Enhancement
Description
Add Opencode AI integration for Cubbi
Configure API keys and model settings
Support MCP server integration
Provide containerized environment with Node.js
Changes walkthrough 📝
opencode_plugin.py
Implement Opencode plugin for configuration managementcubbi/images/opencode/opencode_plugin.py
Google, OpenAI, OpenRouter)
permissions
Dockerfile
Create Docker image for Opencode environmentcubbi/images/opencode/Dockerfile
README.md
Document Opencode image usage and configurationcubbi/images/opencode/README.md
cubbi_image.yaml
Define Opencode image configurationcubbi/images/opencode/cubbi_image.yaml