From 02a908b772eb193aa5c710f9e3486c115e9f6630 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 26 Sep 2024 19:51:58 +0000 Subject: [PATCH 1/5] chore(deps): update dependency ubuntu to v24 --- .github/workflows/galaxy.yml | 2 +- .github/workflows/pre-commit.yml | 2 +- .github/workflows/tests.yml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/galaxy.yml b/.github/workflows/galaxy.yml index e27c954..33b5e26 100644 --- a/.github/workflows/galaxy.yml +++ b/.github/workflows/galaxy.yml @@ -7,7 +7,7 @@ on: jobs: release: - runs-on: ubuntu-20.04 + runs-on: ubuntu-24.04 steps: - name: galaxy uses: robertdebock/galaxy-action@1.2.1 diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index c54a4f1..e4f171c 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -9,7 +9,7 @@ on: jobs: pre-commit: - runs-on: ubuntu-20.04 + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v5 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index b414e85..6faa02d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -29,7 +29,7 @@ jobs: name: Test GHA Runner Role environment: name: test - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 strategy: fail-fast: false max-parallel: 5 @@ -73,7 +73,7 @@ jobs: needs: repo environment: name: test - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 strategy: fail-fast: false max-parallel: 5 From 8f832703fb1855cd000704e6588618e729da687d Mon Sep 17 00:00:00 2001 From: Danny Gilbert <87996558+dgilbert-foreflight@users.noreply.github.com> Date: Mon, 4 Nov 2024 15:06:09 -0600 Subject: [PATCH 2/5] Update install_runner_unix.yml Resolves the following error due to how `ansible_distribution` resolves for macOS distributions ``` TASK [monolithprojects.github_actions_runner : STOP and disable Github Actions Runner service] **************************** fatal: [build-agent-26]: FAILED! => {"changed": true, "cmd": ["./svc.sh", "stop"], "delta": "0:00:00.004103", "end": "2024-11-04 15:02:53.034496", "msg": "non-zero return code", "rc": 1, "start": "2024-11-04 15:02:53.030393", "stderr": "", "stderr_lines": [], "stdout": "Must not run with sudo", "stdout_lines": ["Must not run with sudo"]} ``` --- tasks/install_runner_unix.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tasks/install_runner_unix.yml b/tasks/install_runner_unix.yml index b398de4..f28e633 100644 --- a/tasks/install_runner_unix.yml +++ b/tasks/install_runner_unix.yml @@ -165,7 +165,7 @@ args: chdir: "{{ runner_dir }}" changed_when: true - become: "{{ 'false' if ansible_distribution == 'MacOS' else 'true' }}" + become: "{{ 'false' if ansible_distribution == 'MacOSX' else 'true' }}" no_log: "{{ hide_sensitive_logs | bool }}" ignore_errors: "{{ ansible_check_mode }}" when: runner_state|lower == "stopped" From a9778880e9a18a910aaf49e809b1509d16cd8c02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sofie=20Finnes=20=C3=98vrelid?= Date: Tue, 5 Nov 2024 13:37:00 +0100 Subject: [PATCH 3/5] fix: missing authorization token in collect_info.yml --- tasks/collect_info.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/tasks/collect_info.yml b/tasks/collect_info.yml index a08bf5d..7363686 100644 --- a/tasks/collect_info.yml +++ b/tasks/collect_info.yml @@ -64,6 +64,7 @@ ansible.builtin.uri: url: "https://api.github.com/repos/{{ runner_download_repository }}/releases/latest" headers: + Authorization: "token {{ access_token }}" Content-Type: "application/json" method: GET return_content: true From d0f5807079cbf1c6787cdddd91f4569ace4ca5ba Mon Sep 17 00:00:00 2001 From: danochoa Date: Sat, 4 Jan 2025 23:52:08 -0600 Subject: [PATCH 4/5] add support for ubuntu noble --- README.md | 2 +- tasks/install_deps.yml | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index c8a2574..d5bb785 100644 --- a/README.md +++ b/README.md @@ -263,7 +263,7 @@ In this example the Ansible role will uninstall the runner service and unregiste 2. Install Molecule and its Docker driver with pip: ```bash -pip install molecule[docker] +pip install "molecule-plugins[docker]" ``` Sure, here's a basic example of how you might structure a README to explain how to test the `monolithprojects.github_actions_runner` Ansible role with Molecule: diff --git a/tasks/install_deps.yml b/tasks/install_deps.yml index 8c559e2..0539b5a 100644 --- a/tasks/install_deps.yml +++ b/tasks/install_deps.yml @@ -111,6 +111,18 @@ become: true when: (ansible_facts.distribution == "Ubuntu" and ansible_facts.distribution_major_version == "22") +- name: Install dependencies on Ubuntu Noble systems + ansible.builtin.package: + pkg: + - acl + - liblttng-ust1 + - libkrb5-3 + - zlib1g + state: present + update_cache: true + become: true + when: (ansible_facts.distribution == "Ubuntu" and ansible_facts.distribution_major_version == "24") + - name: Install dependencies on RHEL/CentOS/Fedora systems ansible.builtin.package: name: From be7d147dd7def3f169dea99f61a17b41e1439f86 Mon Sep 17 00:00:00 2001 From: danochoa Date: Sun, 5 Jan 2025 13:38:57 -0600 Subject: [PATCH 5/5] update cmd to install molecule docker plugin --- .github/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 48f411b..1ccd795 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -40,7 +40,7 @@ Do the changes in your own GitHub namespace. 2. Install Molecule and its Docker driver with pip: ```bash -pip install molecule[docker] +pip install "molecule-plugins[docker]" ``` ### Running Tests