fix(proxy): filter requests with empty messages from database storage #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests with an empty messages array were still being stored in the database despite recent fixes for other edge cases. This commit adds a check in MetricsService.storeRequest() to skip storage when messageCount === 0. Changes: - Add empty messages check after calculating messageCount - Skip storage and log debug message when messages array is empty - Add unit test to verify empty message requests are not stored This complements existing filters for non-storable request types (query_evaluation, quota, internal_operation) and empty Bedrock responses. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The previous fix only handled requests with empty messages. This commit adds a second check to filter out empty responses (zero tokens AND empty content array), which commonly occurs with streaming responses that fail or return no meaningful data. Detection criteria for empty responses: - inputTokens === 0 AND - outputTokens === 0 AND - content array is empty or missing This catches: - Empty streaming responses from any provider - Failed streaming connections that produced no content - Edge cases where response reconstruction yields empty data 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MetricsService.storeRequest()to skip storage whenmessageCount === 0Context
Even after recent fixes for empty Bedrock responses and internal operations, two types of "empty" requests were still being stored:
messagesarray is emptyBoth of these pollute the database with non-meaningful request data.
Changes
messageCount === 0inputTokens === 0 AND outputTokens === 0 AND content.length === 0Test plan
🤖 Generated with Claude Code