Use PostInherents to validate timestamp #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmauro
reviewed
Sep 18, 2025
manuelmauro
added a commit
to moonbeam-foundation/moonbeam
that referenced
this pull request
Oct 10, 2025
Upstream PR: Moonsong-Labs/moonkit#83 - "Use PostInherents to validate timestamp" - Author: Rodrigo Quelhas (RomarQ) - Merged: September 30, 2025 Details: This trait item is used in the PostInherents validation to ensure that the configured block time in the node and runtime is compatible with Nimbus's consensus mechanism. The value is set to MILLISECS_PER_BLOCK (12000ms for Moonbeam), matching the parachain's block production time. This change prepares for Polkadot SDK updates that deprecated the CheckInherents parameter in favor of PostInherents validation.
RomarQ
added a commit
to moonbeam-foundation/moonbeam
that referenced
this pull request
Nov 26, 2025
* chore: ⬆️ upgrade dependencies to 2506 * refactor: 🚨 use workspace dependencies in pallet crowdloan rewards * chore: 📌 depend on crates.io ethereum (similarly to frontier) * fix: 🐛 remove PassByCodec PassByCodec was replaced by PassFatPointerAndDecode in paritytech/polkadot-sdk@1cb22ca * fix: 🐛 use Weight::MAX instead of Weight::max_value() * fix: 🐛 add TrieCacheContext parameter to state_at * fix: 🐛 add missing relay_parent_descendants and collator_peer_id fields to ParachainInherentData * fix: 🐛 remove deprecated AssetHubMigrationStarted config * fix: 🐛 update ExecuteXcm::prepare() to accept weight_limit parameter * fix: 🐛 add generic parameters to Sha3FIPS256<Runtime, ()> * fix: 🐛 add metrics field to BuildNetworkParams * chore: 📌 upgrade pins * fix: 🐛 add OnNewHead to bridge parachain configs This adds the required OnNewHead configuration parameter introduced in paritytech/polkadot-sdk#8531 * fix: 🐛 add relay chain slot duration to FixedVelocityConsensusHook * fix: 🐛 add SlotDuration trait items Upstream PR: Moonsong-Labs/moonkit#83 - "Use PostInherents to validate timestamp" - Author: Rodrigo Quelhas (RomarQ) - Merged: September 30, 2025 Details: This trait item is used in the PostInherents validation to ensure that the configured block time in the node and runtime is compatible with Nimbus's consensus mechanism. The value is set to MILLISECS_PER_BLOCK (12000ms for Moonbeam), matching the parachain's block production time. This change prepares for Polkadot SDK updates that deprecated the CheckInherents parameter in favor of PostInherents validation. * fix: 🐛 add RelayParentOffset trait item Upstream PR: paritytech/polkadot-sdk#8299 - "Allow building on older relay parents" - Author: Sebastian Kunert (skunert) - Merged: May 29, 2025 Details: With an offset of 0, blocks are built on the current relay chain tip. Non-zero values allow building on older relay parents (e.g., offset of 2 means building 2 blocks behind the tip) to avoid building on short-lived relay chain forks. The runtime enforces this offset by requiring multiple relay parent descendants to be present in the set_validation_data inherent. * fix: 🐛 refactor build_relay_chain_interface to return only required tuple elements * fix: 🐛 fixed RuntimeOrigin trait bounds by removing From<Option<AccountId>> bound Fixed RuntimeOrigin trait bounds - Removed From<Option<AccountId>> bound and updated all precompiles to use frame_system::RawOrigin::Signed().into() * fix: 🐛 update cumulus_pallet_xcmp_queue WeightInfo methods * fix: 🐛 fix AccountId ambiguity Added proper type qualifications and EncodeLike trait bound in crowdloan-rewards precompile * fix: 🐛 use QueueFootprintQuery trait for message queue footprint method paritytech/polkadot-sdk#8021 * fix: 🐛 remove deprecated RuntimeEvent * fix: 🐛 update the runtime interface to use explicit marshalling strategies PR #7375 - Host/Runtime Interface Refactoring 🔗 paritytech/polkadot-sdk#7375 * fix: 🐛 do not enable SharedTrieCache * fix: 🐛 implement BenchmarkHelper * fix: 🐛 remove PalletTransactionPaymentBenchmark * fix: 🐛 add missing crate in Cargo feature * fix: 🐛 remove RuntimeEvent associated type Polkadot SDK changes: paritytech/polkadot-sdk#7229 * fix: 🐛 remove unused imports * fix: 🐛 remove RuntimeEvent associated type * fix: 🐛 remove AssetHubMigrationStarted associated type * fix: 🐛 add RelayParentOffset associated type * fix: 🐛 add metrics_registry: None to database configuration * fix: 🐛 add warm_up_trie_cache: None to service configuration * fix: 🐛 fix reference to deprecated RuntimeEvent associated type * fix: 🐛 update WeightBounds trait API * fix: 🐛 add missing fields to ParachainInherentData * fix: 🐛 add missing associated types to Runtime * fix: 🐛 replace `Fail(Option<T::Hash>, XcmError)` with `Fail(Option<T::Hash>, InstructionError)` * style: 🎨 format code * fix: 🐛 fix `XcmExecutor::prepare` args * fix: 🐛 impl create_bare from CreateInherent trait * fix: 🐛 mock BenchmarkHelper * fix: ⬆️ upgrade frame-metadata * chore: ⬆️ upgrade polkadot-sdk * fix: 🐛 silence warning * style: 🚨 mark args as unused * fix: 🐛 fix deprecation warning * style: 🎨 format code * test: 🐛 update snapshot * chore: 📌 update pins * refactor: ♻️ move lint directive to root Cargo.toml * chore: ⚡ run benchmarks * chore: ⚡ run benchmarks * test: ✅ assert specific error type * test: ✅ use proper assert_noop! * test: ✅ use new extrinsic for asset transfers using explicit XCM transfer types paritytech/polkadot-sdk#3695 * fix: 🐛 pin udeps Rust nightly version * Revert "fix: 🐛 pin udeps Rust nightly version" This reverts commit 09e6d03. * fix: 🐛 fix some Cargo.toml features * revert: 🔥 remove AssetHubMigrationStarted storage flag * refactor: 🔥 remove unused import * fix: 🐛 add missing feature flags for pallet-assets dependency * refactor: 🚨 remove duplicated feature flags * revert: 🔥 delete file committed by mistake * fix: 📌 properly pin polkadot-sdk version * test: ✅ initialize ParachainSystem HostConfiguration in runtime tests The ParentAsUmp XCM router now validates upward messages by checking HostConfiguration, which was previously uninitialized in test environments, causing ErrorValidating and SendFailure errors. * update polkadot-sdk pin * update polkadot-sdk pin * fix unit tests * update polkadot-sdk pin * fix check-unused-dependencies * fix test * refactor: ♻️ remove IdentityBenchmarkHelper * Revert "refactor: ♻️ remove IdentityBenchmarkHelper" This reverts commit b872ee4. * revert: ⏪ restore pallet_transaction_payment * test: ✅ update tests call_pallet_xcm_with_fee * refactor: ♻️ add mock_abridged_host_config function * fix pallet-identity benchmarks * fix: 🐛 add helper function to set up XCM router for benchmarks * fix: 🐛 add custom delivery helper for Moonbeam * chore: 🔧 update weights * style: 🎨 keep original name TestDeliveryHelper * fix pallet-randomness benchmarks * Revert "chore: 🔧 update weights" This reverts commit ea91959. * test: ✅ update snapshots --------- Co-authored-by: Rodrigo Quelhas <[email protected]> Co-authored-by: Rodrigo Quelhas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for paritytech/polkadot-sdk#9732, which removes the deprecated
CheckInherentsparameter fromregister_validate_block!