fix: 🚑 indexer handling of file deletion (#596)

* fix: 🐛 make it so the indexer handles file deletions more gracefully

* fix: 🐛 add safeguards to file deletion flows in runtime and improve them

* style: 🎨 run cargo fmt

* chore: 🏷️ run typegen

* chore: 🔖 bump api-augment and types-bundle versions

* fix: 🐛 handle edge case for revokes and rejects

* chore: 🔖 bump backend and sdk versions

* docs: 💡 add comments explaining the edge cases we are avoiding

* test: ✅ fix tests that banked on open storage requests being deletable

* style: 🎨 revert whitespace changes

Author: TDemeco

Cargo.lock

@@ -282,6 +282,15 @@ declare module '@polkadot/api-base/types/errors' {
              * Failed to convert to primitive type.
              **/
             FailedTypeConversion: AugmentedError<ApiType>;
+            /**
+             * File has an active storage request and as such is not eligible for deletion.
+             * The user should use the `revoke_storage_request` extrinsic to revoke it first.
+             **/
+            FileHasActiveStorageRequest: AugmentedError<ApiType>;
+            /**
+             * File has an `IncompleteStorageRequest` associated with it and as such is not eligible for a new storage request
+             **/
+            FileHasIncompleteStorageRequest: AugmentedError<ApiType>;
             /**
              * File key already pending deletion.
              **/

api-augment/dist/parachain/interfaces/lookup.js

@@ -4846,7 +4846,9 @@ declare module '@polkadot/types/lookup' {
         readonly isInvalidSignedOperation: boolean;
         readonly isFileKeyMismatch: boolean;
         readonly isIncompleteStorageRequestNotFound: boolean;
-        readonly type: 'StorageRequestAlreadyRegistered' | 'StorageRequestNotFound' | 'StorageRequestNotRevoked' | 'StorageRequestExists' | 'ReplicationTargetCannotBeZero' | 'ReplicationTargetExceedsMaximum' | 'MaxReplicationTargetSmallerThanDefault' | 'NotABsp' | 'NotAMsp' | 'NotASp' | 'BspNotVolunteered' | 'BspNotConfirmed' | 'BspAlreadyConfirmed' | 'StorageRequestBspsRequiredFulfilled' | 'BspAlreadyVolunteered' | 'InsufficientAvailableCapacity' | 'UnexpectedNumberOfRemovedVolunteeredBsps' | 'BspNotEligibleToVolunteer' | 'StorageRequestExpiredNoSlotAvailable' | 'StorageRequestNotAuthorized' | 'MaxTickNumberReached' | 'FailedToEncodeBsp' | 'FailedToEncodeFingerprint' | 'FailedToDecodeThreshold' | 'AboveThreshold' | 'ThresholdArithmeticError' | 'FailedTypeConversion' | 'DividedByZero' | 'ImpossibleFailedToGetValue' | 'BucketIsNotPrivate' | 'BucketNotFound' | 'BucketNotEmpty' | 'NotBucketOwner' | 'ValuePropositionNotAvailable' | 'CollectionNotFound' | 'ProviderRootNotFound' | 'ExpectedNonInclusionProof' | 'ExpectedInclusionProof' | 'InvalidFileKeyMetadata' | 'ThresholdBelowAsymptote' | 'NotFileOwner' | 'FileKeyAlreadyPendingDeletion' | 'BatchFileDeletionMustContainSingleBucket' | 'DuplicateFileKeyInBatchFileDeletion' | 'NoFileKeysToDelete' | 'FailedToPushFileKeyToBucketDeletionVector' | 'FailedToPushUserToBspDeletionVector' | 'FailedToPushFileKeyToBspDeletionVector' | 'MaxUserPendingDeletionRequestsReached' | 'MspNotStoringBucket' | 'FileKeyNotPendingDeletion' | 'FileSizeCannotBeZero' | 'NoGlobalReputationWeightSet' | 'NoBspReputationWeightSet' | 'MaximumThresholdCannotBeZero' | 'TickRangeToMaximumThresholdCannotBeZero' | 'PendingStopStoringRequestNotFound' | 'MinWaitForStopStoringNotReached' | 'PendingStopStoringRequestAlreadyExists' | 'OperationNotAllowedWithInsolventUser' | 'UserNotInsolvent' | 'NotSelectedMsp' | 'MspAlreadyConfirmed' | 'RequestWithoutMsp' | 'MspAlreadyStoringBucket' | 'MoveBucketRequestNotFound' | 'BucketIsBeingMoved' | 'BspAlreadyDataServer' | 'BspDataServersExceeded' | 'FileMetadataProcessingQueueFull' | 'TooManyBatchResponses' | 'TooManyStorageRequestResponses' | 'InvalidBucketIdFileKeyPair' | 'InconsistentStateKeyAlreadyExists' | 'FixedRatePaymentStreamNotFound' | 'DynamicRatePaymentStreamNotFound' | 'CannotHoldDeposit' | 'FailedToQueryEarliestFileVolunteerTick' | 'FailedToGetOwnerAccount' | 'FailedToGetPaymentAccount' | 'NoFileKeysToConfirm' | 'RootNotUpdated' | 'NoPrivacyChange' | 'OperationNotAllowedForInsolventProvider' | 'OperationNotAllowedWhileBucketIsNotStoredByMsp' | 'FailedToComputeFileKey' | 'FailedToCreateFileMetadata' | 'InvalidSignature' | 'ForestProofVerificationFailed' | 'ProviderNotStoringFile' | 'InvalidProviderID' | 'InvalidSignedOperation' | 'FileKeyMismatch' | 'IncompleteStorageRequestNotFound';
+        readonly isFileHasActiveStorageRequest: boolean;
+        readonly isFileHasIncompleteStorageRequest: boolean;
+        readonly type: 'StorageRequestAlreadyRegistered' | 'StorageRequestNotFound' | 'StorageRequestNotRevoked' | 'StorageRequestExists' | 'ReplicationTargetCannotBeZero' | 'ReplicationTargetExceedsMaximum' | 'MaxReplicationTargetSmallerThanDefault' | 'NotABsp' | 'NotAMsp' | 'NotASp' | 'BspNotVolunteered' | 'BspNotConfirmed' | 'BspAlreadyConfirmed' | 'StorageRequestBspsRequiredFulfilled' | 'BspAlreadyVolunteered' | 'InsufficientAvailableCapacity' | 'UnexpectedNumberOfRemovedVolunteeredBsps' | 'BspNotEligibleToVolunteer' | 'StorageRequestExpiredNoSlotAvailable' | 'StorageRequestNotAuthorized' | 'MaxTickNumberReached' | 'FailedToEncodeBsp' | 'FailedToEncodeFingerprint' | 'FailedToDecodeThreshold' | 'AboveThreshold' | 'ThresholdArithmeticError' | 'FailedTypeConversion' | 'DividedByZero' | 'ImpossibleFailedToGetValue' | 'BucketIsNotPrivate' | 'BucketNotFound' | 'BucketNotEmpty' | 'NotBucketOwner' | 'ValuePropositionNotAvailable' | 'CollectionNotFound' | 'ProviderRootNotFound' | 'ExpectedNonInclusionProof' | 'ExpectedInclusionProof' | 'InvalidFileKeyMetadata' | 'ThresholdBelowAsymptote' | 'NotFileOwner' | 'FileKeyAlreadyPendingDeletion' | 'BatchFileDeletionMustContainSingleBucket' | 'DuplicateFileKeyInBatchFileDeletion' | 'NoFileKeysToDelete' | 'FailedToPushFileKeyToBucketDeletionVector' | 'FailedToPushUserToBspDeletionVector' | 'FailedToPushFileKeyToBspDeletionVector' | 'MaxUserPendingDeletionRequestsReached' | 'MspNotStoringBucket' | 'FileKeyNotPendingDeletion' | 'FileSizeCannotBeZero' | 'NoGlobalReputationWeightSet' | 'NoBspReputationWeightSet' | 'MaximumThresholdCannotBeZero' | 'TickRangeToMaximumThresholdCannotBeZero' | 'PendingStopStoringRequestNotFound' | 'MinWaitForStopStoringNotReached' | 'PendingStopStoringRequestAlreadyExists' | 'OperationNotAllowedWithInsolventUser' | 'UserNotInsolvent' | 'NotSelectedMsp' | 'MspAlreadyConfirmed' | 'RequestWithoutMsp' | 'MspAlreadyStoringBucket' | 'MoveBucketRequestNotFound' | 'BucketIsBeingMoved' | 'BspAlreadyDataServer' | 'BspDataServersExceeded' | 'FileMetadataProcessingQueueFull' | 'TooManyBatchResponses' | 'TooManyStorageRequestResponses' | 'InvalidBucketIdFileKeyPair' | 'InconsistentStateKeyAlreadyExists' | 'FixedRatePaymentStreamNotFound' | 'DynamicRatePaymentStreamNotFound' | 'CannotHoldDeposit' | 'FailedToQueryEarliestFileVolunteerTick' | 'FailedToGetOwnerAccount' | 'FailedToGetPaymentAccount' | 'NoFileKeysToConfirm' | 'RootNotUpdated' | 'NoPrivacyChange' | 'OperationNotAllowedForInsolventProvider' | 'OperationNotAllowedWhileBucketIsNotStoredByMsp' | 'FailedToComputeFileKey' | 'FailedToCreateFileMetadata' | 'InvalidSignature' | 'ForestProofVerificationFailed' | 'ProviderNotStoringFile' | 'InvalidProviderID' | 'InvalidSignedOperation' | 'FileKeyMismatch' | 'IncompleteStorageRequestNotFound' | 'FileHasActiveStorageRequest' | 'FileHasIncompleteStorageRequest';
     }
     /** @name PalletProofsDealerProofSubmissionRecord (498) */
     interface PalletProofsDealerProofSubmissionRecord extends Struct {

api-augment/dist/parachain/interfaces/lookup.js.map

@@ -302,6 +302,15 @@ declare module '@polkadot/api-base/types/errors' {
              * Failed to convert to primitive type.
              **/
             FailedTypeConversion: AugmentedError<ApiType>;
+            /**
+             * File has an active storage request and as such is not eligible for deletion.
+             * The user should use the `revoke_storage_request` extrinsic to revoke it first.
+             **/
+            FileHasActiveStorageRequest: AugmentedError<ApiType>;
+            /**
+             * File has an `IncompleteStorageRequest` associated with it and as such is not eligible for a new storage request
+             **/
+            FileHasIncompleteStorageRequest: AugmentedError<ApiType>;
             /**
              * File key already pending deletion.
              **/