feat: 🔊 Add success logs to all tasks and RPCs (#591)

* feat: 🔊 Add success logs to all tasks

* feat: 🔊 Minor improvements in logs

* feat: 🔊 Add end logs to RPC calls

Author: ffarall

client/actors-framework/src/event_bus.rs

@@ -1,5 +1,5 @@
 use anyhow::Result;
-use sc_tracing::tracing::{error, warn};
+use sc_tracing::tracing::{error, info, warn};
 use std::sync::Arc;
 use tokio::sync::{broadcast, Semaphore};
 
@@ -47,7 +47,15 @@ pub trait ProvidesEventBus<T: EventBusMessage> {
 }
 
 pub trait EventHandler<E: EventBusMessage>: Clone + Send + 'static {
-    fn handle_event(&mut self, event: E) -> impl std::future::Future<Output = Result<()>> + Send;
+    /// Handle a single event.
+    ///
+    /// On success, returns a human-readable message that will be logged centrally by the
+    /// event bus listener. This encourages each handler to provide a meaningful success
+    /// description.
+    fn handle_event(
+        &mut self,
+        event: E,
+    ) -> impl std::future::Future<Output = Result<String>> + Send;
 
     fn subscribe_to_provider<EP: ProvidesEventBus<E>>(
         self,
@@ -112,7 +120,9 @@ impl<T: EventBusMessage, E: EventHandler<T> + Send + 'static> EventBusListener<T
                         .expect("To acquire the permit");
                     self.spawner.spawn(async move {
                         match cloned_event_handler.handle_event(event).await {
-                            Ok(_) => {}
+                            Ok(msg) => {
+                                info!("Task completed successfully: {}", msg);
+                            }
                             Err(error) => {
                                 warn!("Task ended with error: {:?}", error);
                             }

client/forest-manager/src/traits.rs

@@ -48,7 +48,7 @@ pub trait ForestStorage<T: TrieLayout, Runtime: StorageEnableRuntime>: 'static {
 #[async_trait]
 pub trait ForestStorageHandler<Runtime: StorageEnableRuntime> {
     /// The key type used to identify forest storage instances.
-    type Key: From<Vec<u8>> + Debug + Send + Sync;
+    type Key: From<Vec<u8>> + AsRef<[u8]> + Debug + Send + Sync;
     /// Type representing the forest storage instance.
     type FS: ForestStorage<StorageProofsMerkleTrieLayout, Runtime> + Send + Sync;