refactor: Calculate bucket stats (file_count, size) using files associated to bucket #578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: we are currently calculating Buckets
file_countandtotal_sizeby increasing/decreasing on file deletion and creation. This method is error prone as it can easily differ to what we actually have in db.Even more, we were seeing a
file_count = U64::MAXin testnet, probably becausefile_countincorrectly with value = 0 and after a deletionfile_count = 0 -1 = U64::MAXSolution: Calculate
file_countandtotal_sizebased on the files associated to the bucket