Skip to content

Conversation

@HermanObst
Copy link
Contributor

Problem: we are currently calculating Buckets file_count and total_size by increasing/decreasing on file deletion and creation. This method is error prone as it can easily differ to what we actually have in db.
Even more, we were seeing a file_count = U64::MAX in testnet, probably because file_count incorrectly with value = 0 and after a deletion file_count = 0 -1 = U64::MAX

Solution: Calculate file_count and total_size based on the files associated to the bucket

…ed to bucket instead of optimistically increase/decrease
@HermanObst HermanObst added B0-silent Changes should not be mentioned in any release notes D3-trivial👶 PR contains trivial changes that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Nov 27, 2025
@HermanObst HermanObst marked this pull request as ready for review November 27, 2025 20:15
@santikaplan santikaplan requested a review from TDemeco December 1, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B0-silent Changes should not be mentioned in any release notes D3-trivial👶 PR contains trivial changes that do not require an audit not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants