-
Notifications
You must be signed in to change notification settings - Fork 11
feat: SIWX #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ftheirs
wants to merge
17
commits into
main
Choose a base branch
from
feat/siwx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: SIWX #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e33a1a9 to
e88fc2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B1-sdknoteworthy
Changes should be mentioned in SH SDK related release notes
B3-backendnoteworthy
Changes should be mentioned in SH backend related release notes
breaking
Needs to be mentioned in breaking changes
D2-noauditneeded🙈
PR doesn't need to be audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend and SDK modifications to support CAIP-122 (SIWX)
Update demo-app to allow the user to use either SIWE or SIWX authentication
Short description
Domain extraction is now automatic from URIs, and session providers are optional when creating MspClient instances.
Who is affected
/auth/nonceor/auth/messagethat previously provided adomainfieldMspClient.auth.SIWE()orMspClient.auth.SIWX()with adomainparameterMspClientinstances with a requiredsessionProviderparameterSuggested code changes
Backend API: Remove
domainfield fromNonceRequestpayloads. The backend extracts the domain from theurifield.SDK - SIWE/SIWX: Remove the
domainparameterSDK - MspClient:
sessionProvideris now optional. You can set it after authentication: