clippy

Author: elfedy

src/service/prompts/analyze_release.rs

@@ -30,7 +30,7 @@ pub(crate) async fn generate_prompt(args: AnalyzeReleaseArgs) -> Vec<PromptMessa
 
     let content = handlebars
         .render_template(TEMPLATE, &context)
-        .unwrap_or_else(|e| format!("Template rendering failed: {}", e));
+        .unwrap_or_else(|e| format!("Template rendering failed: {e}"));
 
     vec![PromptMessage::new_text(PromptMessageRole::User, content)]
 }

src/service/prompts/get_started.rs

@@ -24,7 +24,7 @@ pub(crate) async fn generate_prompt(args: GetStartedArgs) -> Vec<PromptMessage>
 
     let content = handlebars
         .render_template(TEMPLATE, &context)
-        .unwrap_or_else(|e| format!("Template rendering failed: {}", e));
+        .unwrap_or_else(|e| format!("Template rendering failed: {e}"));
 
     vec![PromptMessage::new_text(PromptMessageRole::User, content)]
 }

src/service/prompts/release_comparison.rs

@@ -35,14 +35,14 @@ pub(crate) async fn generate_prompt(
 
     let content = handlebars
         .render_template(TEMPLATE, &context)
-        .map_err(|e| McpError::internal_error(format!("Template rendering failed: {}", e), None))?;
+        .map_err(|e| McpError::internal_error(format!("Template rendering failed: {e}"), None))?;
 
     let description = handlebars
       .render_template(
           "Compare changes between Polkadot SDK versions {{current_version}} and {{target_version}}",
           &context
       )
-      .map_err(|e| McpError::internal_error(format!("Description template rendering failed: {}", e), None))?;
+      .map_err(|e| McpError::internal_error(format!("Description template rendering failed: {e}"), None))?;
 
     Ok(GetPromptResult {
         description: Some(description),

src/service/prompts/scaffold_pallet.rs

@@ -27,7 +27,7 @@ pub(crate) async fn generate_prompt(args: ScaffoldPalletArgs) -> Vec<PromptMessa
 
     let content = handlebars
         .render_template(TEMPLATE, &context)
-        .unwrap_or_else(|e| format!("Template rendering failed: {}", e));
+        .unwrap_or_else(|e| format!("Template rendering failed: {e}"));
 
     vec![PromptMessage::new_text(PromptMessageRole::User, content)]
 }

src/service/prompts/security_review.rs

@@ -30,7 +30,7 @@ pub(crate) async fn generate_prompt(args: SecurityReviewArgs) -> Vec<PromptMessa
 
     let content = handlebars
         .render_template(TEMPLATE, &context)
-        .unwrap_or_else(|e| format!("Template rendering failed: {}", e));
+        .unwrap_or_else(|e| format!("Template rendering failed: {e}"));
 
     vec![PromptMessage::new_text(PromptMessageRole::User, content)]
 }

src/service/tests/helpers/substrate_runner.rs

@@ -64,8 +64,7 @@ fn find_port_from_logs(stderr: ChildStderr) -> io::Result<u16> {
         }
     }
 
-    Err(io::Error::new(
-        io::ErrorKind::Other,
+    Err(io::Error::other(
         "Could not find RPC port in node logs",
     ))
 }

src/service/tools/polkadot_sdk_releases.rs

@@ -748,8 +748,7 @@ mod tests {
             for pr_num in &expected_prs_with_audience {
                 assert!(
                     all_indexed_prs.contains(pr_num),
-                    "PR {} is missing from audience index",
-                    pr_num
+                    "PR {pr_num} is missing from audience index"
                 );
             }
 

src/service/tools/substrate/events.rs

@@ -5,38 +5,6 @@ use subxt::PolkadotConfig;
 
 use super::utils;
 
-/// Represents a decoded event from the chain
-#[derive(Debug, Clone, Serialize, Deserialize)]
-pub(crate) struct DecodedEvent {
-    /// The pallet that emitted the event
-    pub(crate) pallet: String,
-    /// The event variant name
-    pub(crate) variant: String,
-    /// The block number where the event occurred
-    pub(crate) block_number: u32,
-    /// The block hash where the event occurred
-    pub(crate) block_hash: String,
-    /// The event index within the block
-    pub(crate) event_index: u32,
-    /// The decoded event data as JSON
-    pub(crate) data: serde_json::Value,
-}
-
-/// Filter criteria for event queries
-#[derive(Debug, Clone, Serialize, Deserialize)]
-pub(crate) struct EventFilter {
-    /// Filter by pallet name (supports partial matching)
-    pub(crate) pallet: Option<String>,
-    /// Filter by event variant name (supports partial matching)
-    pub(crate) variant: Option<String>,
-    /// Start block number (inclusive)
-    pub(crate) from_block: Option<u32>,
-    /// End block number (inclusive)
-    pub(crate) to_block: Option<u32>,
-    /// Maximum number of events to return
-    pub(crate) limit: Option<usize>,
-}
-
 /// Query events from blocks
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub(crate) struct EventsQuery {
@@ -169,7 +137,7 @@ async fn decode_events_with_subxt(
 
         // Decode event data
         let data = match event.field_values() {
-            Ok(fields) => format!("{}", fields),
+            Ok(fields) => format!("{fields}"),
             Err(e) => format!("Failed to decode call arguments: {e}"),
         };
 

src/service/tools/substrate/extrinsic.rs

@@ -236,7 +236,7 @@ async fn process_extrinsic(
 
     // Decode call arguments
     let args = match extrinsic.field_values() {
-        Ok(fields) => format!("{}", fields),
+        Ok(fields) => format!("{fields}"),
         Err(e) => format!("Failed to decode call arguments: {e}"),
     };