feat: add polkadot upgrade workflow tools and prompts #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add list_polkadot_releases tool to discover available SDK releases - Add find_runtime_pallets tool to analyze project runtime configurations - Add polkadot_upgrade prompt for systematic release impact analysis - Enhance fetch_and_analyze_release with PR labels and structured output - Add GitHub API authentication support via GITHUB_TOKEN env var - Use zeroize crate for secure token handling - Add comprehensive test coverage for runtime discovery
snowmead
force-pushed
the
snowmead/polkadot-upgrade
branch
from
41c8730 to
1f9e852
Compare
- Add is_available() method to check for substrate-node binary - Skip test gracefully with informative message when binary not found - Prevents test failure in CI/environments without substrate-node installed
- Change from skipping to panicking when substrate-node not found - Provide clear error message about requirement to install substrate-node - Ensures CI/developers are aware of the dependency requirement
- Remove '_enhanced' suffix from fetch_and_analyze_release_enhanced - Update all references to use simplified name - No functional changes, just naming consistency
Signed-off-by: Michael Assaf <[email protected]>
…cture - Add comprehensive workflow documentation with agent coordination - Implement three-agent system: Main Orchestrator, Compilation, and Analysis agents - Add evidence-based impact categorization (MUST/OPTIONAL/INHERITED/DON'T KNOW) - Include detailed tracking tables and structured reporting - Add mermaid diagrams for workflow visualization - Enhance prompt template with specific sub-agent instructions - Normalize release input to handle different git tag formats - Add comprehensive README documenting the upgrade analysis process
…cture - Add ULTRATHINK directive for improved analysis - Implement batch processing for PR analysis (10 parallel agents per batch) - Create dedicated analysis directory structure for individual PR reports - Update tracking table to include total PR count and link to analysis files - Add force parameter to fetch_and_analyze_release for cache control - Implement cache loading functionality to avoid redundant downloads - Improve compilation sub-agent requirements and constraints - Clarify single PR analysis requirement for each sub-agent - Add structured report writing to designated analysis files
fetch and analyze release Signed-off-by: Michael Assaf <[email protected]>
elfedy
reviewed
Sep 18, 2025
Collaborator
elfedy
left a comment
elfedy
left a comment
There was a problem hiding this comment.
👏 Nice LGTM. Only catch is that we should probably not log to stdout. If that is addressed then feel free to merge.
| let auth_value = format!("Bearer {}", token.as_str()); | ||
| if let Ok(header_value) = reqwest::header::HeaderValue::from_str(&auth_value) { | ||
| headers.insert(reqwest::header::AUTHORIZATION, header_value); | ||
| log::debug!("Using authenticated GitHub API requests"); |
Collaborator
There was a problem hiding this comment.
Unless I am missing something, stdio transport uses the process stdout for sending messages from the server to the client, and logging things to it might cause unexpected behavior. If we want to log things we should log to stderr or send a logging notification. See here
Collaborator
Author
There was a problem hiding this comment.
I see there is no setup for logging notifications, I will just send it to stderr for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
polkadot_upgradeprompt for systematic release impact analysisNew tools:
list_polkadot_releasestool to discover available SDK releasesfind_runtime_palletstool to analyze project runtime configurationsAdd GitHub API authentication to enable higher rate limits