feat: ✨ Add strETH (StrategyETH Flexible Vaults) Asset Adapter
#126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tq-oracle into feat/streth-asset-adapter-sher
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for strETH (StrategyETH Flexible Vaults) to the oracle pipeline by introducing a new asset adapter and updating the report structure to include TVL in the base asset.
Key changes:
- Added
tvl_in_base_assetfield toOracleReportdata structure - Implemented
StrETHAdapterfor fetching strETH positions via on-chain multicalls - Integrated ABIs for Multicall and CoreVaultsCollector contracts
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tq_oracle/report/generator.py | Added tvl_in_base_asset parameter and field to report generation |
| src/tq_oracle/adapters/asset_adapters/streth.py | New adapter implementing strETH position fetching with multicall |
| src/tq_oracle/adapters/asset_adapters/init.py | Registered StrETHAdapter in adapter registry |
| src/tq_oracle/pipeline/assets.py | Integrated strETH adapter into asset fetching pipeline |
| src/tq_oracle/pipeline/report.py | Updated report builder to pass TVL parameter |
| src/tq_oracle/constants.py | Added strETH, multicall, and collector contract addresses |
| src/tq_oracle/settings.py | Added configuration properties for strETH components |
| src/tq_oracle/abi.py | Added loader functions for new contract ABIs |
| src/tq_oracle/abis/Multicall.json | Multicall3 contract ABI definition |
| src/tq_oracle/abis/CoreVaultsCollector.json | CoreVaultsCollector contract ABI definition |
| tests/report/test_generator.py | Updated tests to include tvl_in_base_asset parameter |
| tests/report/test_encoder.py | Updated test fixtures with tvl_in_base_asset field |
| tests/report/test_publisher.py | Updated test fixture with tvl_in_base_asset field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
superseded by #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for the strETH asset in the oracle pipeline, including a new asset adapter, ABI integration, and configuration updates. It also updates the report structure to include the total value locked (TVL) in the base asset, and adds comprehensive tests for these changes.