feat: ✨ Add extra_addresses validation
#134
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
extra_addresseslist in theidle_balancesadapter config, you can add any address you like for scraping extra balances. This can be problematic if adding accounts unrelated to the vault in question (e.g. if typo or copy/paste error).This PR now adds new checks to ensure that any extra addresses added to the idle_balances config has a public view function that can be called
.subvault()which returns an address in that vault's list of subvaults. This is the case with the Swapper component being used on pre-prod:0x17aeabfd3cb214a8757bf07d2e248d526c8c4809This PR also adds an override to turn off this check for testing, which is gated by the
--allow-dangerousCLI option flag