fix: 🛠️ add warning for negative strETH #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
timbrinded
December 5, 2025 16:01
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a warning log to detect and report negative asset balances in the strETH asset adapter. The change improves observability by alerting when the strETH collector returns unexpected negative balances, which helps with debugging potential issues in the upstream data collection.
Key changes:
- Added a warning log in the
_fetch_assetsmethod when a negative balance is encountered
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a warning log for negative asset balances in the
strethasset adapter. The main change is to improve observability and debugging for unexpected negative balances returned by the strETH collector.Logging and observability improvements:
_fetch_assetsmethod ofstreth.pyto notify when a negative balance is encountered for an asset, including the asset name and amount.