fix: 🛠️ add warning for negative strETH #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbrinded
merged commit 7f8991d
into
audit/sherlock-combined-RC1
23 of 24 checks passed
Copilot finished reviewing on behalf of
timbrinded
December 5, 2025 16:12
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds observability improvements to the strETH asset adapter by logging warnings when negative asset balances are encountered from the strETH collector. The change helps identify unexpected data conditions while still processing the balances for accurate tracking. The implementation follows existing logging patterns in the codebase and provides clear diagnostic information including the asset address and negative amount value.
Key changes:
- Added warning log in
_fetch_assetsmethod when negative balances are detected - Negative balances are still processed in cumulative amounts after logging
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a warning log for negative asset balances in the streth asset adapter. The main change is to improve observability and debugging for unexpected negative balances returned by the strETH collector.
Logging and observability improvements:
Added a warning log message in the _fetch_assets method of streth.py to notify when a negative balance is encountered for an asset, including the asset name and amount.