Skip to content

Commit d3c518a

Browse files
committed
refactor: Change the expected result of some tests
1 parent a512a0b commit d3c518a

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

tests/CPlugin.Net/Core/PluginLoaderTests.cs

+4-7
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public void Load_WhenPluginsAreFound_ShouldBeLoadedIntoMemory()
2121
int expectedCommands = 2;
2222
var expectedVersions = new[]
2323
{
24-
"Version=12.0.0.0",
25-
"Version=13.0.0.0"
24+
"Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed",
25+
"Newtonsoft.Json, Version=12.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed"
2626
};
2727

2828
// Act
@@ -31,11 +31,8 @@ public void Load_WhenPluginsAreFound_ShouldBeLoadedIntoMemory()
3131
var versions = commands.Select(command =>
3232
{
3333
var json = command.Execute();
34-
// Example: Newtonsoft.Json, Version=12.0.0.0, Culture=neutral, PublicKeyToken=null[0]
35-
var version = JsonConvert.DeserializeObject<Info>(json).Version;
36-
// Example: Version=12.0.0.0
37-
return version.Split(",")[1].Trim();
38-
}).ToList();
34+
return JsonConvert.DeserializeObject<Info>(json).Version;
35+
}).ToArray();
3936

4037
// Asserts
4138
commands.Should().HaveCount(expectedCommands);

tests/CPlugin.Net/Core/TypeFinderTests.cs

+4-8
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,14 @@ public void FindSubtypesOf_WhenSubtypesArePresent_ShouldReturnsInstancesOfSubtyp
3131
{
3232
typeof(TypeFinderTests).Assembly
3333
};
34-
int expectedValue = 1;
34+
int[] expectedValues = { 1, 1 };
3535

3636
// Act
3737
var runners = TypeFinder.FindSubtypesOf<IRunner>(assemblies);
38+
int[] values = runners.Select(runner => runner.Run()).ToArray();
3839

39-
// Asserts
40-
runners.Should().HaveCount(2);
41-
foreach(IRunner runner in runners)
42-
{
43-
int value = runner.Run();
44-
value.Should().Be(expectedValue);
45-
}
40+
// Assert
41+
values.Should().BeEquivalentTo(expectedValues);
4642
}
4743

4844
[Test]

0 commit comments

Comments
 (0)