Skip to content

Commit 6e8ec5d

Browse files
author
MritunjayTiwari14
committed
home: Expand tap area for correct feedback.
Added Gesture Detector over Column, Temporary set the onPressed of the Icon Button to null. Fixes: zulip#1808
1 parent 9950e84 commit 6e8ec5d

File tree

1 file changed

+30
-25
lines changed

1 file changed

+30
-25
lines changed

lib/widgets/home.dart

Lines changed: 30 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -264,31 +264,36 @@ class _NavigationBarButton extends StatelessWidget {
264264
return AnimatedScaleOnTap(
265265
scaleEnd: 0.875,
266266
duration: const Duration(milliseconds: 100),
267-
child: Column(
268-
children: [
269-
SizedBox(
270-
height: 34,
271-
child: IconButton(
272-
icon: Icon(icon, size: 24),
273-
onPressed: onPressed,
274-
style: IconButton.styleFrom(
275-
// TODO(#417): Disable splash effects for all buttons globally.
276-
splashFactory: NoSplash.splashFactory,
277-
highlightColor: designVariables.navigationButtonBg,
278-
shape: const RoundedRectangleBorder(
279-
borderRadius: BorderRadius.all(Radius.circular(4))),
280-
).copyWith(foregroundColor: iconColor)),
281-
),
282-
Text(
283-
label,
284-
style: TextStyle(
285-
fontSize: 12,
286-
color: textColor,
287-
height: 1.0,),
288-
textAlign: TextAlign.center,
289-
maxLines: 2,
290-
overflow: TextOverflow.ellipsis)
291-
]));
267+
child: GestureDetector(
268+
onTap: onPressed,
269+
child: Column(
270+
children: [
271+
SizedBox(
272+
height: 34,
273+
child: IconButton(
274+
icon: Icon(icon, size: 24),
275+
onPressed: null,
276+
style: IconButton.styleFrom(
277+
// TODO(#417): Disable splash effects for all buttons globally.
278+
splashFactory: NoSplash.splashFactory,
279+
highlightColor: designVariables.navigationButtonBg,
280+
shape: const RoundedRectangleBorder(
281+
borderRadius: BorderRadius.all(Radius.circular(4))),
282+
).copyWith(foregroundColor: iconColor)),
283+
),
284+
Expanded(
285+
child: Text(
286+
label,
287+
style: TextStyle(
288+
fontSize: 12,
289+
color: textColor,
290+
height: 1.0,),
291+
textAlign: TextAlign.center,
292+
maxLines: 2,
293+
overflow: TextOverflow.ellipsis),
294+
)
295+
]),
296+
));
292297
}
293298
}
294299

0 commit comments

Comments
 (0)