Skip to content

Remove einsum #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Remove einsum #31

wants to merge 3 commits into from

Conversation

AntonOresten
Copy link
Member

After some thinking in #22, #26, #30, I've decided einsum isn't suited for this package.

In this PR, I also implement some changes I wanted for a v0.2 release, like requiring Val patterns for parse_shape, since it was only type stable without Val if there was no ellipsis.

For a v0.2 release I'm also considering removing EllipsisNotation.jl dependency since it increases the package compile time from 1 second to like 20 seconds because of StaticArrayInterface.jl.

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ddad75d) to head (4d3cf0d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #31      +/-   ##
===========================================
+ Coverage   98.04%   100.00%   +1.95%     
===========================================
  Files          12        11       -1     
  Lines         307       274      -33     
===========================================
- Hits          301       274      -27     
+ Misses          6         0       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant