Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a /redeem route #901

Open
futurepaul opened this issue Feb 22, 2024 · 6 comments
Open

Add a /redeem route #901

futurepaul opened this issue Feb 22, 2024 · 6 comments

Comments

@futurepaul
Copy link
Collaborator

We have three (THREE!) new ways to get money into mutiny in PRs currently:

#885
#891
#837

All three work on the premise of you pasting in something, and then you see some sort of preview, and then you click a button and get the money. (Potentially gifting can work like this as well, although rn it has its own path / ux)

LnurlW is a bit different because it can, optionally, have an editable receive amount, afaik cashu and fedi oob will always be fixed amounts.

I plan on building the /redeem route to unify these, just wanted to make this a discussion issue of any thoughts / gotchas I might need to have in mind when trying to unify the UX here.

@oleonardolima @elnosh @tompro any thoughts / special considerations I should be aware of?

@elnosh
Copy link
Contributor

elnosh commented Feb 23, 2024

not sure where/how it should be handled but wondering about cases where the amount of the cashu token pasted is very low. Should we show a warning or something instead of a redeem button if the amount is too low?

@oleonardolima
Copy link
Contributor

[...] afaik cashu and fedi oob will always be fixed amounts.

yes, at least for fedimint the oob's have fixed amounts

[...] I plan on building the /redeem route to unify these, just wanted to make this a discussion issue of any thoughts / gotchas I might need to have in mind when trying to unify the UX here.

I don't have any specific thoughts about it, and I agree that unifying it would be better.

The only thing is that currently, OOB would only work with copy/paste and not through QR, could that lead to bad UX somehow ? 🤔

@benthecarman
Copy link
Collaborator

@elnosh what would too low mean, it's all burned to fees?

@elnosh
Copy link
Contributor

elnosh commented Feb 23, 2024

maybe something below 5 sats. That could end up going most of it in fees.

@tompro
Copy link
Contributor

tompro commented Feb 24, 2024

I just noticed that current LNUrlW implementation does not give access to the invoice that is processed. Showing a QR (that is never used) does not make much sense during processing. It will need access to the tx to show the exact received amt in the success screen later though.

@EthnTuttle
Copy link

not sure where/how it should be handled but wondering about cases where the amount of the cashu token pasted is very low. Should we show a warning or something instead of a redeem button if the amount is too low?

You can just offer to trust the origin mint and do a swap instead of melting the cashu to LN. Then no fees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants