MIR-1352 Use mycore text editor for editing xml documents #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possommi
changed the title
kkrebs
reviewed
Nov 5, 2024
| @@ -40,7 +40,7 @@ | |||
| <when condition="(group = admin) or (group = editor)" url="/servlets/MCRLockServlet?url=/editor/editor-admins.xed" /> | |||
| </action> | |||
| <action action="update-xml"> | |||
| <when condition="(group = admin)" url="/servlets/MCRLockServlet?url=/editor/editor-xml.xed" /> | |||
There was a problem hiding this comment.
D.h. das Objekt wird dann nicht mehr gelockt und kann somit gleichzeitig bearbeitet werden?
... ausserdem sollten wir dringend eine ACL auf die URL setzen um die Bearbeitung durch nicht-Admins zu vermeiden
There was a problem hiding this comment.
ACL bringt da nichts. Wenn man die URL als Nichtadmin aufruft, sieht man nur das XML, kann es aber nicht bearbeiten.
There was a problem hiding this comment.
Gerade geprüft, das MCRLockServlet hat auch bei der alten Variante keinen Effekt 👀
There was a problem hiding this comment.
Doch, das hat einen Effekt und sollte daher auch weiter funktionieren.
Possommi
force-pushed
the
issues/MIR-1352-Use-new-mycore-text-editor-to-edit-xml
branch
4 times, most recently
from
5b38cf0 to
ed3ad7e
Compare
Possommi
force-pushed
the
issues/MIR-1352-Use-new-mycore-text-editor-to-edit-xml
branch
from
ed3ad7e to
e07989c
Compare
|
Da es sich doch deutlich anders verhalten wird als bisher, schlagen wir ein rebase auf main vor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIR-1352