MCR-3481 Make MCREventManager discovery compatible with configurable classes #2599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toKrause
force-pushed
the
issues/MCR-3481_Make-MCREventManager-discovery-compatible-with-configurable-classes
branch
from
9a7f12f to
4b433c5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MCREventManager's discovery mechanism to be compatible with configurable classes by improving how event handler properties are parsed and categorized. The change separates class-based properties (ending with ".Class") from mode-based properties and ensures proper filtering to avoid conflicts between different configuration patterns.
Key changes:
- Refactored property filtering logic to distinguish between class-based and mode-based configurations
- Added comprehensive comments explaining the property parsing logic
- Improved property collection to handle both configuration patterns correctly
mycore-base/src/main/java/org/mycore/common/events/MCREventManager.java
Outdated
Show resolved
Hide resolved
mycore-base/src/main/java/org/mycore/common/events/MCREventManager.java
Outdated
Show resolved
Hide resolved
mycore-base/src/main/java/org/mycore/common/events/MCREventManager.java
Outdated
Show resolved
Hide resolved
toKrause
force-pushed
the
issues/MCR-3481_Make-MCREventManager-discovery-compatible-with-configurable-classes
branch
from
4b433c5 to
6ea07e7
Compare
toKrause
force-pushed
the
issues/MCR-3481_Make-MCREventManager-discovery-compatible-with-configurable-classes
branch
from
6ea07e7 to
51531ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.