Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Makefile in circom-circuit Directory #50

Open
susumutomita opened this issue Dec 28, 2023 · 0 comments
Open

Issues with Makefile in circom-circuit Directory #50

susumutomita opened this issue Dec 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@susumutomita
Copy link
Collaborator

What command(s) is the bug in?

make init

Describe the bug

Title: Issues with Makefile in circom-circuit Directory

Issue Description

Summary:

Encountered multiple issues with the Makefile in the circom-circuit directory of the myna-wallet-monorepo. These issues hinder the initialization process and affect the proper execution of make commands.

Problems Identified:

  1. Directory Creation Failure: The init command in the Makefile fails if the directories already exist. The command mkdir ./setup && mkdir ./build leads to an error if either of these directories is present, halting the initialization process.

    Error message received:

    mkdir: ./setup: File exists
    make: *** [init] Error 1
  2. Powers of Tau File Download URL Potential Mismatch: The current URL used in the curl command within the init target fetching powersOfTau28_hez_final_19.ptau but after steps uses powersOfTau28_hez_final_20.ptau. It looks the intended version of the Powers of Tau file misconfigured.

  3. Incorrect Powers of Tau File Path: In the gov-sig-build-circuit and user-sig-build-circuit targets, the file path to the Powers of Tau file appears to be outdated or incorrect. This issue could lead to problems in circuit compilation and verification due to the use of an incorrect version of the Powers of Tau file.

Suggested Solutions:

  • For the directory creation issue, updating the mkdir command to use the -p flag could prevent the error when directories already exist.
  • The Powers of Tau file paths and download URLs in the make targets should be verified and updated to ensure they are correct and up-to-date.

Concrete steps to reproduce the bug. If it's able reproduce via testool, please share test_id from jenkins report

Issue 1

  1. go to myna-wallet-monorepo/packages/circom-circuit
  2. run make init
  3. run make init again

Issue2

  1. go to myna-wallet-monorepo/packages/circom-circuit
  2. run make init

Issue3

  1. go to myna-wallet-monorepo/packages/circom-circuit
  2. run make init
  3. run make gov-sig-build-circuit
  4. run make gov-sig-setup-groth16
    or
  5. go to myna-wallet-monorepo/packages/circom-circuit
  6. run make init
  7. run make user-sig-build-circuit
  8. run make user-sig-setup-groth16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant