Prepare for release 3.1.0

Resolve PMD warnings

Author: dmfrey

app/src/main/java/org/mythtv/android/data/net/ContentApiImpl.java

@@ -45,6 +45,7 @@
  *
  * Created on 10/17/15.
  */
+@SuppressWarnings( "PMD" )
 public class ContentApiImpl extends BaseApi implements ContentApi {
 
     private static final String TAG = ContentApiImpl.class.getSimpleName();

app/src/main/java/org/mythtv/android/data/net/DvrApiImpl.java

@@ -55,6 +55,7 @@
  *
  * Created on 8/27/15.
  */
+@SuppressWarnings( "PMD" )
 public class DvrApiImpl extends BaseApi implements DvrApi {
 
     private static final String TAG = DvrApiImpl.class.getSimpleName();

app/src/main/java/org/mythtv/android/data/net/VideoApiImpl.java

@@ -46,6 +46,7 @@
  *
  * Created on 11/9/15.
  */
+@SuppressWarnings( "PMD" )
 public class VideoApiImpl extends BaseApi implements VideoApi {
 
     private static final String TAG = VideoApiImpl.class.getSimpleName();

app/src/main/java/org/mythtv/android/data/repository/datasource/DbSearchDataStore.java

@@ -47,6 +47,7 @@
  *
  * Created on 10/8/15.
  */
+@SuppressWarnings( "PMD" )
 public class DbSearchDataStore implements SearchDataStore {
 
     private static final String TAG = DbSearchDataStore.class.getSimpleName();

app/src/main/java/org/mythtv/android/presentation/mapper/MediaItemModelMapper.java

@@ -36,7 +36,7 @@ public MediaItemModel transform( MediaItem mediaItem ) {
             errors.add( ErrorModel.fromError( error ) );
         }
 
-        MediaItemModel mediaItemModel = MediaItemModel.create(
+        return MediaItemModel.create(
                 mediaItem.id(),
                 mediaItem.media(),
                 mediaItem.title(),
@@ -67,9 +67,6 @@ public MediaItemModel transform( MediaItem mediaItem ) {
                 mediaItem.parentalLevel(),
                 mediaItem.recordingGroup(),
                 errors );
-
-
-        return mediaItemModel;
     }
 
     public List<MediaItemModel> transform( Collection<MediaItem> mediaItemCollection ) {

app/src/main/java/org/mythtv/android/presentation/presenter/phone/EncoderListPresenter.java

@@ -45,6 +45,7 @@
  *
  * Created on 8/31/15.
  */
+@SuppressWarnings( "PMD" )
 public class EncoderListPresenter extends DefaultSubscriber<List<Encoder>> implements Presenter {
 
     private static final String TAG = EncoderListPresenter.class.getSimpleName();

app/src/main/java/org/mythtv/android/presentation/presenter/phone/MediaItemDetailsPresenter.java

@@ -47,6 +47,7 @@
  *
  * Created on 8/31/15.
  */
+@SuppressWarnings( "PMD" )
 public class MediaItemDetailsPresenter implements Presenter {
 
     private static final String TAG = MediaItemDetailsPresenter.class.getSimpleName();

app/src/main/java/org/mythtv/android/presentation/presenter/phone/MediaItemListPresenter.java

@@ -47,6 +47,7 @@
  *
  * Created on 9/15/16.
  */
+@SuppressWarnings( "PMD" )
 public class MediaItemListPresenter extends DefaultSubscriber<List<MediaItem>> implements Presenter {
 
     private static final String TAG = MediaItemListPresenter.class.getSimpleName();

app/src/main/java/org/mythtv/android/presentation/presenter/phone/SearchResultListPresenter.java

@@ -48,6 +48,7 @@
  *
  * Created on 10/14/15.
  */
+@SuppressWarnings( "PMD" )
 public class SearchResultListPresenter extends DefaultSubscriber<List<MediaItem>> implements Presenter {
 
     private static final String TAG = SearchResultListPresenter.class.getSimpleName();

app/src/main/java/org/mythtv/android/presentation/presenter/phone/SeriesListPresenter.java

@@ -46,6 +46,7 @@
  *
  * Created on 9/15/16.
  */
+@SuppressWarnings( "PMD" )
 public class SeriesListPresenter extends DefaultSubscriber<List<Series>> implements Presenter {
 
     private static final String TAG = SeriesListPresenter.class.getSimpleName();