Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine image - PHP with --allow-embed #4

Open
scheibling opened this issue Mar 31, 2023 · 2 comments
Open

Alpine image - PHP with --allow-embed #4

scheibling opened this issue Mar 31, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@scheibling
Copy link

Stumbled on this as I was building my own version of the container, there is an easy way to compile the Alpine PHP Container to include the --allow-embed flag.

If you clone the repo at https://github.com/docker-library/php.git, the only thing that needs to be added is the --enable-embed flag in the following section

https://github.com/docker-library/php/blob/5bfc95d4880599cf9e85f5b5f99940cf123ebcf0/8.0/alpine3.16/cli/Dockerfile#L119-L163

@xZero707 xZero707 changed the title PHP-Image Alpine image - PHP with --allow-embed Apr 3, 2023
@xZero707 xZero707 self-assigned this Apr 3, 2023
@xZero707 xZero707 added enhancement New feature or request good first issue Good for newcomers labels Apr 3, 2023
@xZero707
Copy link
Member

xZero707 commented Apr 3, 2023

Hi @scheibling .
I will look into this. Thank you very much.

One of the reasons this was not investigated much is that I want to avoid maintaining own PHP base images.
I will try to see if we can add this flag at this stage, but I doubt it.

Meanwhile, feel free to create PR if you have PoC.

@xZero707 xZero707 added the help wanted Extra attention is needed label Aug 28, 2023
@scheibling
Copy link
Author

Don't have the time for a full PR at the moment, but I have a lot of code for this at github.com/cloudynes/docker-unit if you or anyone wants to have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants