Fix bug preventing file overwrite in move and copy

Author: Mythicaeda

workspace-server/src/main/java/gov/nasa/jpl/aerie/workspace/server/WorkspaceFileSystemService.java

@@ -160,17 +160,14 @@ public boolean saveFile(final int workspaceId, final Path filePath, final Upload
 
   @Override
   public boolean moveFile(final int oldWorkspaceId, final Path oldFilePath, final int newWorkspaceId, final Path newFilePath)
-  throws NoSuchWorkspaceException, SQLException, WorkspaceFileOpException
+  throws NoSuchWorkspaceException, SQLException
   {
     final var oldRepoPath = postgresRepository.workspaceRootPath(oldWorkspaceId);
     final var oldPath = resolveSubPath(oldRepoPath, oldFilePath);
     final var newRepoPath = (oldWorkspaceId == newWorkspaceId) ? oldRepoPath : postgresRepository.workspaceRootPath(newWorkspaceId);
     final var newPath = resolveSubPath(newRepoPath, newFilePath);
     boolean success = true;
 
-    // Do not move the file if the destination already exists
-    if(newPath.toFile().exists()) throw new WorkspaceFileOpException("Destination file \"%s\" in workspace %d already exists.".formatted(newFilePath, newWorkspaceId));
-
     // Find hidden metadata files, if they exist, and move them
     final var metadataExtensions = postgresRepository.getMetadataExtensions();
     for(final var extension : metadataExtensions) {
@@ -197,9 +194,6 @@ public boolean copyFile(final int sourceWorkspaceId, final Path sourceFilePath,
       // Do not copy the file if the source file does not exist
       if(!sourcePath.toFile().exists()) throw new WorkspaceFileOpException("Source file \"%s\" in workspace %d does not exist.".formatted(sourceFilePath, sourceWorkspaceId));
 
-      // Do not copy the file if the destination already exists
-      if(destPath.toFile().exists()) throw new WorkspaceFileOpException("Destination file \"%s\" in workspace %d already exists.".formatted(destFilePath, destWorkspaceId));
-
       // Create any parent directories that don't already exist
       Files.createDirectories(destPath.getParent());