Skip to content

Conversation

@dandelany
Copy link
Collaborator

Description

Improvements to action server to support new features:

  • Update aerie-actions to support loading adaptations in actions, param descriptions & other features
  • User authentication when passing transient secrets to actions
  • Extract JWT from secrets requests & pass it into action context, so actions may send authed requests to Hasura/other apps
  • Pass username and action run id to actions, per user feedback
  • Fix issue with action runs accidentally overwriting action-server's process.env reference by changing how we pass global context down to actions.
  • Separate app.js from server.js for better testability, add test for authenticating user JWT

…URA_GRAPHQL_JWT_SECRET env var to aerie_action container
…tions will use user auth token to make hasura requests
…ype field specified by HASURA_GRAPHQL_JWT_SECRET
@dandelany
Copy link
Collaborator Author

dandelany commented Nov 13, 2025

Thanks @Mythicaeda I addressed all your notes, with one outstanding on-the-fence question i'll make a decision about tomorrow, ready for another look.

Ignore the failing tests for the moment - they were passing and will pass again after I publish a new version of the aerie-actions API with the updated config etc - I'll make sure they pass before merging.

Copy link
Contributor

@Mythicaeda Mythicaeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presuming tests start passing once the aerie-actions code has been updated, this LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants