-
Notifications
You must be signed in to change notification settings - Fork 26
Actions improvements - JWT, user info, adaptations in actions #1762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…action loader overwriting action-server process.env
…URA_GRAPHQL_JWT_SECRET env var to aerie_action container
…tions will use user auth token to make hasura requests
…ype field specified by HASURA_GRAPHQL_JWT_SECRET
|
Thanks @Mythicaeda I addressed all your notes, with one outstanding on-the-fence question i'll make a decision about tomorrow, ready for another look. Ignore the failing tests for the moment - they were passing and will pass again after I publish a new version of the aerie-actions API with the updated config etc - I'll make sure they pass before merging. |
Mythicaeda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presuming tests start passing once the aerie-actions code has been updated, this LGTM
Description
Improvements to action server to support new features:
aerie-actionsto support loading adaptations in actions, param descriptions & other features[email protected]and update dependencyprocess.envreference by changing how we pass global context down to actions.app.jsfromserver.jsfor better testability, add test for authenticating user JWT