Merge pull request #375 from mgharamti/dartlab_rh

Fixing rank histogram calculations in DART-LAB

Author: hkershaw-brown

.github/workflows/release.yml

@@ -22,7 +22,12 @@ individual files.
 
 The changes are now listed with the most recent at the top.
 
+**July 21 2022 :: Bug-fix for DART_LAB rank histograms. Tag: v10.0.4**
+
+- Fixes DART_LAB prior and posterior rank histogram calculation.
+
 **July 14 2022 :: Performance improvement - removal of redundant caching. Tag: v10.0.3**
+
 - Reduces the runtime by removing redundant caching in the get_close_obs_cached and 
   get_close_state_cached subroutines in assim_tools_mod.f90
 

CHANGELOG.rst

@@ -21,7 +21,7 @@
 author = 'Data Assimilation Research Section'
 
 # The full version, including alpha/beta/rc tags
-release = '10.0.3'
+release = '10.0.4'
 master_doc = 'README'
 
 # -- General configuration ---------------------------------------------------

conf.py

@@ -844,7 +844,7 @@ function step_ahead()
             temp_rank(:, 2) = 0;
 
             % Compute the prior rank histograms
-            for i = 1:handles.ens_size
+            for i = 1:handles.model_size
                 ens_rank = get_ens_rank(squeeze(handles.prior(new_time, i, :)), squeeze(new_truth(i)));
                 handles.prior_rank(ens_rank) = handles.prior_rank(ens_rank) + 1;
                 temp_rank(ens_rank, 2) = temp_rank(ens_rank, 2) + 1;
@@ -937,7 +937,7 @@ function step_ahead()
             temp_rank(:, 2) = 0;
 
             % Compute the posterior rank histograms
-            for i = 1:handles.ens_size
+            for i = 1:handles.model_size
                 ens_rank = get_ens_rank(squeeze(handles.posterior(time, i, :)), ...
                     squeeze(handles.true_state(time, i)));
                 handles.posterior_rank(ens_rank) = handles.posterior_rank(ens_rank) + 1;

guide/DART_LAB/matlab/run_lorenz_96.m

@@ -1318,7 +1318,7 @@ function step_ahead()
             temp_rank(:, 2) = 0;
 
             % Compute the prior rank histograms
-            for i = 1:handles.ens_size
+            for i = 1:handles.model_size
                 ens_rank = get_ens_rank(squeeze(handles.prior(new_time, i, :)), ...
                     squeeze(new_truth(i)));
                 handles.prior_rank(ens_rank) = handles.prior_rank(ens_rank) + 1;
@@ -1455,7 +1455,7 @@ function step_ahead()
             temp_rank(:, 2) = 0;
 
             % Compute the posterior rank histograms
-            for i = 1:handles.ens_size
+            for i = 1:handles.model_size
                 ens_rank = get_ens_rank(squeeze(handles.posterior(time, i, :)), ...
                     squeeze(handles.true_state(time, i)));
                 handles.posterior_rank(ens_rank) = handles.posterior_rank(ens_rank) + 1;