Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect record use_Stanley_ML when USE_BODNER23 is true #328

Open
gustavo-marques opened this issue Dec 26, 2024 · 1 comment
Open

Incorrect record use_Stanley_ML when USE_BODNER23 is true #328

gustavo-marques opened this issue Dec 26, 2024 · 1 comment

Comments

@gustavo-marques
Copy link
Collaborator

I think parameter CS%use_Stanley_ML is being recorded incorrectly when USE_BODNER23 is true; see here.

First, use_Stanley_ML is not implemented in subroutine mixedlayer_restrat_Bodner, so making it available with this option does not make sense.

Second, were use_Stanley_ML a valid option for mixedlayer_restrat_Bodner, the get_param should use USE_STANLEY_ML instead of USE_STANLEY_TVAR.

I suggest we remove this. call to avoid confusion.

This can be added to #327

@iangrooms
Copy link

Agreed. I will put it on my list to add the Stanley density correction to the Bodner ML code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants