Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generalized gen_ideal_test.py #131

Open
scrasmussen opened this issue Jun 13, 2022 · 5 comments
Open

More generalized gen_ideal_test.py #131

scrasmussen opened this issue Jun 13, 2022 · 5 comments

Comments

@scrasmussen
Copy link
Member

Expected Behavior

gen_ideal_test.py should be restored to previous version to be truly a generalized test case. Or a new method that is more generalized and easier to produce tests with should be created.

Current Behavior

gen_ideal_test.py is an ideal test case for the Sleve work in #128

Possible Solution

gen_ideal_test.py should be moved to gen_sleve_ideal_test.py and the previous gen_ideal_test.py should be stored or a new idea test case that is more generalized and easier to produce tests with should be created.

@gutmann
Copy link
Member

gutmann commented Jun 13, 2022

Thanks Soren, the solution I would like to see (when someone has time) is gen_ideal_test with no CLI arguments does what it used to, then
gen_ideal_test.py --sleve generates the test from PR #126 (aka #128 )
gen_ideal_test.py --schar02 generates the test in PR #127
or something like that if possible.

@gutmann
Copy link
Member

gutmann commented Jun 13, 2022

better still would be that, plus an option to give it a yaml file that lets the user specify every option the ideal test can take. (that will make it easy to use for CI testing with a lot of different cases too...)

@scrasmussen
Copy link
Member Author

better still would be that, plus an option to give it a yaml file that lets the user specify every option the ideal test can take. (that will make it easy to use for CI testing with a lot of different cases too...)

This shouldn't be too difficult, I'll look into it and start working it

@gutmann
Copy link
Member

gutmann commented Jan 23, 2023

@scrasmussen is it fair to say that it is somewhat general now, or do you still need to add more configurability to it?

@scrasmussen
Copy link
Member Author

@gutmann thanks for the reminder. I have a branch laying around with the changes I wanted, I just need to merge in the upstream changes and then create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants