Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added netcdf #273

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Added netcdf #273

wants to merge 8 commits into from
+233 −30

Conversation

montythind
Copy link
Contributor

CMD argument is available to define type of file.
Units have been added to csv file header
units added to header in netcdf

close #238

K20shores
K20shores requested changes Nov 4, 2024
View reviewed changes
src/acom_music_box/music_box.py Outdated Show resolved Hide resolved
src/acom_music_box/music_box.py Show resolved Hide resolved
K20shores
K20shores requested changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@K20shores K20shores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes in the code. Would you also please add some tests?

src/acom_music_box/data_output.py Outdated Show resolved Hide resolved
src/acom_music_box/data_output.py Outdated Show resolved Hide resolved
src/acom_music_box/data_output.py Outdated Show resolved Hide resolved
src/acom_music_box/music_box.py Outdated Show resolved Hide resolved
src/acom_music_box/music_box.py Outdated Show resolved Hide resolved
src/acom_music_box/data_output.py Outdated Show resolved Hide resolved
K20shores
K20shores requested changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@K20shores K20shores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add instructions to the readme that list how to output either csv, netcdf, or printing the csv to the screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K20shores K20shores K20shores requested changes

@mattldawson mattldawson Awaiting requested review from mattldawson

@boulderdaze boulderdaze Awaiting requested review from boulderdaze

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow netcdf output
2 participants
@montythind @K20shores