Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for get_orcid_name #157

Open
dmullen17 opened this issue Jan 15, 2020 · 0 comments
Open

Error handling for get_orcid_name #157

dmullen17 opened this issue Jan 15, 2020 · 0 comments

Comments

@dmullen17
Copy link
Member

dmullen17 commented Jan 15, 2020

get_orcid_name is a helper function called by list_submissions that attends to scrape an orcid url and return the submitter's name. It looks like this is failing in some cases and it could use some error handling so that it doesn't cause the function call to fail.

Here are examples of the two cases:

cn <- dataone::CNode('PROD')
adc <- dataone::getMNode(cn,'urn:node:ARCTIC')

list_submissions(adc, '2019-09-01', '2020-01-15') # this fails
list_submissions(adc, '2020-01-01', '2020-01-15') # this succeeds 

An easy way to do this would be to just include some text to default to if it fails like "Orcid not found".

@rachelsun97 if you want to take this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant