Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if auth.deniedSubmitters still and how works #2004

Open
taojing2002 opened this issue Oct 28, 2024 · 4 comments
Open

Test if auth.deniedSubmitters still and how works #2004

taojing2002 opened this issue Oct 28, 2024 · 4 comments

Comments

@taojing2002
Copy link
Contributor

Request from smithsonian:

Is anyone familiar enough with MetacatUI access policies to know if you can create a group that would serve as a “blocklist” to >prevent certain users from submitting? Smithsonian is asking whether this is possible, since they are considering opening >submissions to the public.
yes, but its done a little differently. Set allowedSubmitters to the group in metacat.properties
ah, right. I think they were asking because they didn’t want to maintain a big group of submitters like that.
Check with jing on how the allow lists and deny lists get merged

@taojing2002
Copy link
Contributor Author

Also deniedSumitters is easy to bypass. If they change to another orcid, they can submit again.

@taojing2002
Copy link
Contributor Author

I quickly went through code and found the deny property should still work. We only allow users who are in the allowed list AND not in the denied list to create/update objects.

return (isAllowedSubmitter(username, groups) && !isDeniedSubmitter(username, groups));

@iannesbitt
Copy link

Thank you @taojing2002

@iannesbitt
Copy link

I think all they need is to be able to block certain ORCiDs, I don’t think they’re too concerned about people switching accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants