Skip to content

Update news detail widget JS #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 of 7 tasks
jfrank-nih opened this issue Mar 17, 2025 · 0 comments · Fixed by #187
Closed
6 of 7 tasks

Update news detail widget JS #143

jfrank-nih opened this issue Mar 17, 2025 · 0 comments · Fixed by #187
Assignees
@belaolsonNIH
Labels
task
Milestone
mynci_1.3

Comments

@jfrank-nih
Copy link
Member

jfrank-nih commented Mar 17, 2025 •
edited
Loading

  • Move modules/NewsDetailWidget.js to modules/callbacks/NewsDetailWidget.js
    • Rename the export to newsDetailWidget_callbacks
    • Update the import function in the main digitalworkplace.custom.js file
  • Rename functions
    • Rename the function from NCINewsDetailUICallback to newsDetail_ui_prepSlider
    • Rename the function from NewsDetailContactCallback to newsdetail_data_addContactInfo
    • Update the widget instances that use the callbacks to point to the new names
belaolsonNIH added a commit that referenced this issue Apr 10, 2025
@belaolsonNIH
(#143) Update news detail widget JS
a347569 
* Moved newsDetailWidget.js into callbacks folder and updated imports.
* Renamed export function to newsDetailWidget_callbacks
* Updated import function in digitalworkplace.custom.js to reflect change
* Renamed NCINewsDetailUICallback to newsDetail_ui_prepSlider
* Renamed NewsDetailContactCallback to newsDetail_data_addContactInfo
* Updated config to reflect changes

Closes #143
@belaolsonNIH belaolsonNIH mentioned this issue Apr 11, 2025
Merged
jfrank-nih pushed a commit that referenced this issue Apr 11, 2025
@belaolsonNIH @jfrank-nih
(#143) Update news detail widget JS
142d655 
* Moved newsDetailWidget.js into callbacks folder and updated imports.
* Renamed export function to newsDetailWidget_callbacks
* Updated import function in digitalworkplace.custom.js to reflect change
* Renamed NCINewsDetailUICallback to newsDetail_ui_prepSlider
* Renamed NewsDetailContactCallback to newsDetail_data_addContactInfo
* Updated config to reflect changes

Closes #143
jfrank-nih pushed a commit that referenced this issue Apr 15, 2025
@belaolsonNIH @jfrank-nih
(#143) Update news detail widget JS
3b41a00 
* Moved newsDetailWidget.js into callbacks folder and updated imports.
* Renamed export function to newsDetailWidget_callbacks
* Updated import function in digitalworkplace.custom.js to reflect change
* Renamed NCINewsDetailUICallback to newsDetail_ui_prepSlider
* Renamed NewsDetailContactCallback to newsDetail_data_addContactInfo
* Updated config to reflect changes

Closes #143
jfrank-nih pushed a commit that referenced this issue Apr 18, 2025
@belaolsonNIH @jfrank-nih
(#143) Update news detail widget JS
f2cc92c 
* Moved newsDetailWidget.js into callbacks folder and updated imports.
* Renamed export function to newsDetailWidget_callbacks
* Updated import function in digitalworkplace.custom.js to reflect change
* Renamed NCINewsDetailUICallback to newsDetail_ui_prepSlider
* Renamed NewsDetailContactCallback to newsDetail_data_addContactInfo
* Updated config to reflect changes

Closes #143
@jfrank-nih jfrank-nih mentioned this issue Apr 19, 2025
Merged
jfrank-nih pushed a commit that referenced this issue Apr 19, 2025
@belaolsonNIH @jfrank-nih
(#143) Update news detail widget JS
a4cf07c 
* Moved newsDetailWidget.js into callbacks folder and updated imports.
* Renamed export function to newsDetailWidget_callbacks
* Updated import function in digitalworkplace.custom.js to reflect change
* Renamed NCINewsDetailUICallback to newsDetail_ui_prepSlider
* Renamed NewsDetailContactCallback to newsDetail_data_addContactInfo
* Updated config to reflect changes

Closes #143
jfrank-nih pushed a commit that referenced this issue Apr 24, 2025
@belaolsonNIH @jfrank-nih
(#143) Update news detail widget JS
b20af35 
* Moved newsDetailWidget.js into callbacks folder and updated imports.
* Renamed export function to newsDetailWidget_callbacks
* Updated import function in digitalworkplace.custom.js to reflect change
* Renamed NCINewsDetailUICallback to newsDetail_ui_prepSlider
* Renamed NewsDetailContactCallback to newsDetail_data_addContactInfo
* Updated config to reflect changes

Closes #143
jfrank-nih pushed a commit that referenced this issue Apr 25, 2025
@belaolsonNIH @jfrank-nih
(#143) Update news detail widget JS
8667582 
* Moved newsDetailWidget.js into callbacks folder and updated imports.
* Renamed export function to newsDetailWidget_callbacks
* Updated import function in digitalworkplace.custom.js to reflect change
* Renamed NCINewsDetailUICallback to newsDetail_ui_prepSlider
* Renamed NewsDetailContactCallback to newsDetail_data_addContactInfo
* Updated config to reflect changes

Closes #143
jfrank-nih pushed a commit that referenced this issue Apr 25, 2025
@belaolsonNIH @jfrank-nih
(#143) Update news detail widget JS
c522117 
* Moved newsDetailWidget.js into callbacks folder and updated imports.
* Renamed export function to newsDetailWidget_callbacks
* Updated import function in digitalworkplace.custom.js to reflect change
* Renamed NCINewsDetailUICallback to newsDetail_ui_prepSlider
* Renamed NewsDetailContactCallback to newsDetail_data_addContactInfo
* Updated config to reflect changes

Closes #143
@welshja welshja added this to the mynci_1.3 milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@belaolsonNIH belaolsonNIH

Labels
task
Projects
None yet
Milestone
mynci_1.3
Development

Successfully merging a pull request may close this issue.

(#115) Restructure Javascript NCIOCPL/akumina-mynci
3 participants
@welshja @jfrank-nih @belaolsonNIH