Skip to content

Update people directory widget JS #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
5 tasks
jfrank-nih opened this issue Mar 18, 2025 · 0 comments
Open
5 tasks

Update people directory widget JS #144

jfrank-nih opened this issue Mar 18, 2025 · 0 comments
Assignees
@belaolsonNIH
Labels
task

Comments

@jfrank-nih
Copy link
Member

jfrank-nih commented Mar 18, 2025 •
edited
Loading

  • Remove the PushPeopleContainerUnderTab function and move all of its contents into window.NCITABOrganizationDirectory since it's only used there
  • Move the file to modules/callbacks/PeopleDirectoryWidget.js exporting peopleDirectoryWidget_callbacks
  • Rename the functions and update the widget instances where they are called from (search the code for the original function names):
    - [ ] NCITABOrganizationDirectory to tab_html_prepOrgTabs
    - [ ] NCIGenericItemPropcallback to genericItem_data_setOrgDescription
    - [ ] NCIGenericSearchPropcallback to genericSearchList_query_setOrgSearch
    - [ ] OrganizationDirectorySearchResultsCallBack to genericSearchList_data_searchOrgs
    - [ ] LoadOrganizationDirectoryTreeFilter to peopleDirectory_html_loadOrgs
    - [ ] NCIDirectoryOrgCallBackUI to peopleDirectory_ui_addOrgDirTabs
  • Move the fireWhen code into a new peopleDirectory_html_loadTabs function; then in site/src/js/widgets/PeopleDirectoryWidget/views/NCIOrgDirectoryView.html add a new line to execute that function at the very top of the last script tag
  • Update digitalworkplace.custom.js with the proper new import
belaolsonNIH added a commit that referenced this issue Apr 14, 2025
@belaolsonNIH
(#144) Update people directory widget JS
d835048 
* Renamed NCITABOrganizationDirectory to tab_html_prepOrgTabs
* Renamed NCIGenericItemPropcallback to genericItem_data_setOrgDescription
* Renamed NCIGenericSearchPropcallback to genericSearchList_query_setOrgSearch
* OrganizationDirectorySearchResultsCallBack to genericSearchList_data_searchOrgs
* LoadOrganizationDirectoryTreeFilter to peopleDirectory_html_loadOrgs
* NCIDirectoryOrgCallBackUI to peopleDirectory_ui_addOrgDirTabs
* Moved FireWhen into peopleDirectory_html_loadTabs function
* renamed export function to peopleDirectoryWidget_callbacks
* Updated imports

Closes #144
@belaolsonNIH belaolsonNIH mentioned this issue Apr 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@belaolsonNIH belaolsonNIH

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfrank-nih @belaolsonNIH