Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote but possible singularity in two-stream code #1276

Open
rgknox opened this issue Oct 31, 2024 · 0 comments · May be fixed by #1277
Open

remote but possible singularity in two-stream code #1276

rgknox opened this issue Oct 31, 2024 · 0 comments · May be fixed by #1277

Comments

@rgknox
Copy link
Contributor

rgknox commented Oct 31, 2024

We have some code that avoids a mathematical singularity in two-stream, see here:

https://github.com/NGEET/fates/blob/main/radiation/TwoStreamMLPEMod.F90#L952-L977

I just realized that it's possible that a correction that is applied to prevent a singularity in the NIR band (second loop index) could actually generate conditions for a singularity in the visible band (the first loop index).

This seems incredibly unlikely, but when you do this billions of times in and ESM, a one in a billion probability could crash your model.

@rgknox rgknox linked a pull request Oct 31, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❕Todo
Development

Successfully merging a pull request may close this issue.

1 participant