FATES_MORTALITY_CFLUX_CANOPY and FATES_MORTALITY_CFLUX_USTORY have wrong units

[sshu88]

Describe the issue

A recent check of FATES outputs by @qzhu-lbl found that the unit of both canopy and understory mortality C fluxes seem to be in the rate of yr-1 instead of s-1. A closer look at the code shows three different treatments for different causes of mortality:

1. natural caused mortality C fluxes have been converted to s-1 rate correctly:
   

   fates/main/FatesHistoryInterfaceMod.F90

   Line 2908 in a19c26d

   hio_canopy_mortality_carbonflux_si(io_si) = hio_canopy_mortality_carbonflux_si(io_si) + &

2. fire caused mortality C flux
   

   fates/main/FatesHistoryInterfaceMod.F90

   Line 2579 in a19c26d

   hio_canopy_mortality_carbonflux_si(io_si) = hio_canopy_mortality_carbonflux_si(io_si) + &

   
   

   fates/biogeochem/EDPatchDynamicsMod.F90

   Line 977 in a19c26d

   currentSite%fmort_carbonflux_canopy(currentCohort%pft) = &

   
   and termination mortality C flux
   

   fates/main/FatesHistoryInterfaceMod.F90

   Line 2596 in a19c26d

   hio_canopy_mortality_carbonflux_si(io_si) = hio_canopy_mortality_carbonflux_si(io_si) + &

   
   are converted to s-1 rate at daily timestep without averaging but accumulating to yearly output.
3. No conversion to rate for logging caused mortality C flux:
   

   fates/main/FatesHistoryInterfaceMod.F90

   Line 2912 in a19c26d

   (ccohort%lmort_direct + ccohort%lmort_collateral + ccohort%lmort_infra) * total_m * &

I might have overlooked codes that converted these fluxes into rate before passing into FatesHistoryInterface or a PR in the queue that already addressed this issue. Please leave comments to correct. Otherwise I plan to submit a PR to fix the unit.

Relevant log output

FATES tag

sci.1.48.0_api.17.0.0-1636-gc14dc2f4

Host land model tag

e3sm v2.0.0-14252-ge9515ed7a8

Machine

perlmutter

Other supported machine name

No response

Additional context

No response

[glemieux]

@sshu88 I think this might be addressed by #1252, which should be integrated this week. See the new cohort method SumMortForHistory.

[sshu88]

Thank you for the response @glemieux.