-
Notifications
You must be signed in to change notification settings - Fork 105
Description
Task description
I am working on implementing a btran-based metric for drought deciduous phenology (main issue #1385), and I think for it to really work and avoid hydraulic failure mortality, we need to track the minimum daily btran instead of the daily average. I imagine at some point we may want a similar capability for maximum daily value, so I will likely implement it as well.
This is how I plan to implement this in FatesRunningMeanMod:
- Edit
rmean_typeclass to add four more variables (c_minimum,l_minimum,c_maximum,l_maximum. - Add functions
GetMinandGetMaxto retrieve the minimum and maximum. - Edit functions
InitRMean,UpdateRMean,FuseRMeanandCopyFromDonorso they handle the new variables too. - Existing flag
moving_ema_windowwill be applied to the mean only, not the minima and maxima, which will always use the fixed windows.
With this, it may make sense to rename the module, structure names and functions. I am thinking of FatesRunningSummaryMod, rsummary_def_type and rsummary_type, InitRSummary, etc. but I am open to other suggestions (including not changing it at all). Also, I suppose I should make this a separate pull request before bringing in the btran-based phenology, what do you think?
Metadata
Metadata
Assignees
Labels
Type
Projects
Status