Skip to content

resp_excess_hold missing from set_restart_vectors #1447

@glemieux

Description

@glemieux

Describe the issue

resp_excess_hold is only present in get_restart_vectors.

This doesn't seem to be much of an issue normally given that it appears that this value is always set to zero during the call to ed_integrate_state_variables:

fates/main/EDMainMod.F90

Lines 587 to 589 in 49cd7d0

currentCohort%resp_excess_hold = 0._r8

As such, I only discovered this when trying to resolve an exact restart issue during testing of the new feature in e3sm-project#7231 which requires that gpp_site be updated prior to the dynamics driver call to ed_integrate_state_variables.

Relevant log output

FATES tag

sci.1.86.3_api.40.0.0

Host land model tag

ctsm5.3.065

Machine

perlmutter

Other supported machine name

No response

Additional context

The variable is NaN during cohort initialization, and seeing these values in the exact restart fix tipped me off to something being wrong with the inputs to gpp_site during restart.

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    ✔ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions