-
Notifications
You must be signed in to change notification settings - Fork 105
Description
Some history diagnostics have their registries defined in the wrong groups. This is a problem because if they are not in the correct group, their index will not be added to the registry at the right time and will trigger errors if hist dimension levels are less than 2.
FATES_NCL
Registered only if if(hlm_hist_level_dynam>1):
https://github.com/NGEET/fates/blob/main/main/FatesHistoryInterfaceMod.F90#L7127-L7131
But used if hlm_hist_level_dynam==1:
https://github.com/NGEET/fates/blob/main/main/FatesHistoryInterfaceMod.F90#L2414
FATES_PATCHAREA is wrongly classified, but shouldn't cause errors, because it it classified AND used as a dimlevel = 2 variable:
https://github.com/NGEET/fates/blob/main/main/FatesHistoryInterfaceMod.F90#L7133-L7136
https://github.com/NGEET/fates/blob/main/main/FatesHistoryInterfaceMod.F90#L3375-L3376
FATES_ZSTAR:
registered: https://github.com/NGEET/fates/blob/main/main/FatesHistoryInterfaceMod.F90#L7184-L7188
used: https://github.com/NGEET/fates/blob/main/main/FatesHistoryInterfaceMod.F90#L2654
There might be a couple of others, but this is a simple fix and I'll hunt them down
Metadata
Metadata
Assignees
Labels
Type
Projects
Status